Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190712151329.11333-1-luiz.dentz@gmail.com> <CABBYNZLDFAJgkfAFWOOAAqqiX8mpi3KgirBkpwpnBFJ3TxPqyg@mail.gmail.com>
 <20190718100024.ii2igadxb2lmmitm@pali> <20190721155522.3vqt7vsprhpxflqf@pali>
In-Reply-To: <20190721155522.3vqt7vsprhpxflqf@pali>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Sat, 10 Aug 2019 09:54:52 +0300
Message-ID: <CABBYNZK6cuz9n4Hu9uRCbQvn9uFEYkn9=mY8J5Fqu0u-D3B1EA@mail.gmail.com>
Subject: Re: [PATCH BlueZ 1/4] doc/media-api: Add RegisterApplication method
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi,

On Sun, Jul 21, 2019 at 6:55 PM Pali Roh=C3=A1r <pali.rohar@gmail.com> wrot=
e:
>
> On Thursday 18 July 2019 12:00:24 Pali Roh=C3=A1r wrote:
> > On Saturday 13 July 2019 17:52:46 Luiz Augusto von Dentz wrote:
> > > Hi Pali,
> > >
> > > On Fri, Jul 12, 2019 at 6:13 PM Luiz Augusto von Dentz
> > > <luiz.dentz@gmail.com> wrote:
> > > >
> > > > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> > > >
> > > > This uses application ObjectManager to discover the MediaEndpoint a=
nd
> > > > MediaPlayer object of an application and deprecates the use of
> > > > RegisterEndpoint and RegisterPlayer.
> > > > ---
> > > >  doc/media-api.txt | 20 ++++++++++++++++++++
> > > >  1 file changed, 20 insertions(+)
> > > >
> > > > diff --git a/doc/media-api.txt b/doc/media-api.txt
> > > > index bca8c9563..07f7ac3e0 100644
> > > > --- a/doc/media-api.txt
> > > > +++ b/doc/media-api.txt
> > > > @@ -66,7 +66,27 @@ Methods              void RegisterEndpoint(objec=
t endpoint, dict properties)
> > > >
> > > >                         Unregister sender media player.
> > > >
> > > > +               void RegisterApplication(object root, dict options)
> > > >
> > > > +                       Register endpoints an player objects within=
 root
> > > > +                       object which must implement ObjectManager.
> > > > +
> > > > +                       The application object path together with t=
he D-Bus
> > > > +                       system bus connection ID define the identif=
ication of
> > > > +                       the application.
> > > > +
> > > > +                       Possible errors: org.bluez.Error.InvalidArg=
uments
> > > > +                                        org.bluez.Error.AlreadyExi=
sts
> > > > +
> > > > +               void UnregisterApplication(object application)
> > > > +
> > > > +                       This unregisters the services that has been
> > > > +                       previously registered. The object path para=
meter
> > > > +                       must match the same value that has been use=
d
> > > > +                       on registration.
> > > > +
> > > > +                       Possible errors: org.bluez.Error.InvalidArg=
uments
> > > > +                                        org.bluez.Error.DoesNotExi=
st
> > > >  Media Control hierarchy
> > > >  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
> > > >
> > > > --
> > > > 2.21.0
> > >
> > > Can you try this set?
> >
> > Hello, I will try it later in next week. To test it would mean to
> > rewrite pulseaudio bluetooth modules to use this new API, so it would
> > take me longer time.
>
> Hi! I looked at it. But I do not know how to implement
> GetManagedObjects() method via libdbus properly. Any idea?

I went ahead and applied this set, you can find some examples of how
to implement ObjectManager interface in gdbus but I guess what you
really need to do is make PA aware of the objects being exposed since
it does make it simpler to to enumerate objects by the clients.

--=20
Luiz Augusto von Dentz