Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp210335ybl; Mon, 12 Aug 2019 14:49:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqzFxEKk2w3cwImZ6eYk9kKmvgzR2dGjCFDhHCiHQD2NVdPQXNqSKUPHijiGBLFIaplBoyjz X-Received: by 2002:a17:902:45:: with SMTP id 63mr18177211pla.264.1565646570333; Mon, 12 Aug 2019 14:49:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565646570; cv=none; d=google.com; s=arc-20160816; b=AX8KNMi2gZEvmtHfDY3ZbmyDCQLBpDsymcUtg8DJFLRbX4xSxEljvgMkzpwxy8qBQJ sk/lbHtxYklIHiwnHLrG2OPq0sgONxY1SC4wMCRHruS8WNHy0wzqwcc7vZ0QOIDkZpmU /sd97bQTcm5xfYcx1hm4mvE9pCdyLYD5tghDcRu1HSxozVDNd55gMZUvtAupaTUJdaGE 9XKGxxyrVFLHSaBRAkbuJIXxAhKk7oeUscacAzl1cNWgHA6XHRttBeyNMKKVrim8pLjF go0MP5SO40TycMjLg9dOrIJFMHjmWH+zg5Alpgy3Jjy8LtvD3cEOpDyQU6yBNrqr7jNY 2tUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=nkr+gIxBqJFzbWoJfHgW3m7rzqgw9KiVs/6RGjZDRIE=; b=IJGmWaS7FY1DF1InI3pZVBpJyNFsqzYWrl2M9zzx9RtYq/b66U9NgUriyMnCWreL+u wNlCrV2q4ZS2nFID8lxQ45mu45ylCMBhI2HkSJepu3U4dvg3kqHcX4hoLoyZF4/C4imG p5aqgq0pGEQV3lv6+cU0b3FQv/hY9iNOPEWOBQNaxKT4Ef2RuzYE3mnQowYqXEtAO6+z yfeppYH/nrTSJriL+igiOFiF4WsgCU+mBf9wTikVSyTsP9kBOXIK5NbSbwvZUBRCvdh3 nNCS1L8BK1ysOJ8eMluhj7X5isvvXoZhRc2+NnsqbJvWhmLUKPMIbY7ykSW/6HsQfV7Z pu3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gb3s9Sv3; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c14si63053246pgc.244.2019.08.12.14.48.57; Mon, 12 Aug 2019 14:49:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gb3s9Sv3; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726549AbfHLVqo (ORCPT + 99 others); Mon, 12 Aug 2019 17:46:44 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:37982 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbfHLVqo (ORCPT ); Mon, 12 Aug 2019 17:46:44 -0400 Received: by mail-ot1-f68.google.com with SMTP id r20so14930486ota.5; Mon, 12 Aug 2019 14:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nkr+gIxBqJFzbWoJfHgW3m7rzqgw9KiVs/6RGjZDRIE=; b=gb3s9Sv3HPzBuaC3EiLO0FNuc/94OYMO3ZLktnyjaS+lDLsYD/udOgs1bduzDvAQIp wKA/z462vLytjz4AxyK4uufltfvTRd67Up6etwBvtOpZx6iX6Ev0eznFpRXZkUO3VRZ0 9aYqTU6+3Dy7SPqRIwbhzzGnxsMCbFcKFjSF2SiaVjWM8Qt4ZT3gpCj9d9HAeWGTY6jQ 9hyjTDQE6EStrFkTq/p0Uhqxa5vyLNHoCPaOqykjKt7dAEy3ueXRONeg+TkgVT9dZUWX CFwX9wT3ycD/ni656k2S6FCk/ZecJ0/Qov43udnJ2dmslJokvq7fnfEjbM8Z2DoTvQBH 1dNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nkr+gIxBqJFzbWoJfHgW3m7rzqgw9KiVs/6RGjZDRIE=; b=KXem9y0r5Ijr9CpewkBnm6TBEz5eJqM0nflZ1yQaT9TWK5V3H9e5zuEZu2/DsWmow2 qSWAuTeL5UfnuenLBZNny1uh8GUxvuIrSlgBhhkiUeBLfo0BuIOdLshrHo613y/HJmhW giO0TdqKKA8fq041r32BqT6shtC9tKLXDnuOxcru9H39eQRINInxHyN57pchdp+xmUoR NMuzw0syf0ElQa1ADmo/B/nZF44/l6qRVo971x58yszlcssM4svcwBcI2VB9pEE6RFV4 vOgb96DZiuw7V2Tfk3bOrY820wXOsHP7jkEiXYfAqueNUtsXzr9+2BXykihfSygZhtz8 eICQ== X-Gm-Message-State: APjAAAUSKwrXdut20kWi8hwBdcr+M2WNzVlcBhi1c6jYXXTSP04czPhI TN3qs8QwoZQ+L2FC2Cc9CVfvBdKjH+pKvD6GTB1cqw== X-Received: by 2002:a02:a1c7:: with SMTP id o7mr40873256jah.26.1565646402920; Mon, 12 Aug 2019 14:46:42 -0700 (PDT) MIME-Version: 1.0 References: <20190802120217.GA8712@toshiba> In-Reply-To: From: Dmitry Torokhov Date: Mon, 12 Aug 2019 14:46:32 -0700 Message-ID: Subject: Re: [PATCH v2] Bluetooth: btusb: Fix suspend issue for Realtek devices To: Marcel Holtmann Cc: Alex Lu , Johan Hedberg , linux-bluetooth@vger.kernel.org, lkml , Max Chou Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Mon, Aug 12, 2019 at 9:36 AM Marcel Holtmann wrote= : > > Hi Alex, > > > From the perspective of controller, global suspend means there is no > > SET_FEATURE (DEVICE_REMOTE_WAKEUP) and controller would drop the > > firmware. It would consume less power. So we should not send this kind > > of SET_FEATURE when host goes to suspend state. > > Otherwise, when making device enter selective suspend, host should send > > SET_FEATURE to make sure the firmware remains. > > > > Signed-off-by: Alex Lu > > --- > > drivers/bluetooth/btusb.c | 34 ++++++++++++++++++++++++++++++---- > > 1 file changed, 30 insertions(+), 4 deletions(-) > > this one doesn=E2=80=99t apply cleanly to bluetooth-next. Can you please = send a version that does. Is this a chip issue or system issue? I.e. if in some system BT controller is wired so that it loses power over system suspend, this is quite different form chip itself losing firmware in certain situations, and this smells like a system issue and thus needs to be addressed on system level. Thanks. --=20 Dmitry