Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp845538ybl; Wed, 14 Aug 2019 06:54:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxMbzVerCRLZG14BCjez1k2IMddGLAKgwlVhmTJHF/2UjA5HPuiZa8zSN89EslnsH6rzav+ X-Received: by 2002:a62:b615:: with SMTP id j21mr29406pff.190.1565790855081; Wed, 14 Aug 2019 06:54:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565790855; cv=none; d=google.com; s=arc-20160816; b=E5KY8gV8njn3mNueDA5bYKAWsMrYs+7pqB7wsM6JdwR66eCxquOLK9v6OPwc9mMDI5 EXAYcvJ1uo8iIDlz6GFh8uVFP9+T/3xsu19DjDMwI6DnJG1iUvd2louSmVhSQEu30kQZ MPSfMnPEjCkwLExY+str64d54Q+LkjX6Yp7F1TIt892hkckQRfgtGHEV7SmOdPFJ+pqA Z0Zk2/aSOpf6WF6aDqeXHZeoO2cS+exn2bJfR/QDIvlAdETNO9RS7M+t3MqdcNi5LmbX UEnwTFVBBMqMZ2kLZSIGZlB+Q3ddQYBICuSQXjhIrplXZigXrenP06lV5NMNLV38yypr Bk0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=iKTQzzO6ECy4P1wSW5Tw1af745QUb5ykqkymsxKJWLk=; b=i0HJ+C/NZcmfePruREC9jY4BtsD6N2m/KwEyhkE3AUqwjJfaJWaJ1sjh/kHvpzBH71 XW7f1ncjZSPHAoeFH35Y7hcwc348SPbfuunTQpbXW3YRqOojATQoRNtl2rhZyREsIW1C XQkqoVoIXrMGJX5oGiCh94J2fXrgCRvfUttPDHv5UH9VnDfejGfrQw+9FGym9TkvLPeW cVYP5J1Wpxwx3AZWGc2+yPuCJvpVG36sxfUwblhAgKyqcJrircoMhi32wZHuVLBbh7cg CdaAWhFe+smciv0W3BKLN3re0kEi6WY8/8s3RJCogeGJktauuaHDvjVnlfddJutZmS0t 2lTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d9si65695903pgo.355.2019.08.14.06.54.00; Wed, 14 Aug 2019 06:54:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbfHNNxm (ORCPT + 99 others); Wed, 14 Aug 2019 09:53:42 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:57072 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726263AbfHNNxm (ORCPT ); Wed, 14 Aug 2019 09:53:42 -0400 Received: from marcel-macbook.fritz.box (p4FEFC580.dip0.t-ipconnect.de [79.239.197.128]) by mail.holtmann.org (Postfix) with ESMTPSA id A728ECED0B; Wed, 14 Aug 2019 16:02:22 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH v3] Bluetooth: btusb: Fix suspend issue for Realtek devices From: Marcel Holtmann In-Reply-To: <20190814120252.GA4572@toshiba> Date: Wed, 14 Aug 2019 15:53:40 +0200 Cc: Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Max Chou Content-Transfer-Encoding: 7bit Message-Id: References: <20190814120252.GA4572@toshiba> To: Alex Lu X-Mailer: Apple Mail (2.3445.104.11) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Alex, > From the perspective of controller, global suspend means there is no > SET_FEATURE (DEVICE_REMOTE_WAKEUP) and controller would drop the > firmware. It would consume less power. So we should not send this kind > of SET_FEATURE when host goes to suspend state. > Otherwise, when making device enter selective suspend, host should send > SET_FEATURE to make sure the firmware remains. > > Signed-off-by: Alex Lu > --- > Changes in v3: > - Change to fit for bluetooth-next > Changes in v2: > - Change flag to be more descriptive > - Delete pointless #ifdef CONFIG_BT_HCIBTUSB_RTL and #endif > > drivers/bluetooth/btusb.c | 34 ++++++++++++++++++++++++++++++---- > 1 file changed, 30 insertions(+), 4 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel