Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190816074333.24673-1-rpigott@berkeley.edu> <20190816074333.24673-2-rpigott@berkeley.edu>
In-Reply-To: <20190816074333.24673-2-rpigott@berkeley.edu>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 16 Aug 2019 14:29:13 +0300
Message-ID: <CABBYNZL-Pbwg=DUW5a0Q+Xo7R7KeCMx4KkPHQ5LEaUZttze_2g@mail.gmail.com>
Subject: Re: [PATCH BlueZ 1/3] client/main: add help option for available args
To:     Ronan Pigott <rpigott314@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Ronan Pigott <rpigott@berkeley.edu>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Ronan,

On Fri, Aug 16, 2019 at 10:46 AM Ronan Pigott <rpigott314@gmail.com> wrote:
>
> From: Ronan Pigott <rpigott@berkeley.edu>

Can you a description of what the changes does, perhaps a sample when
uses in some command.

> ---
>  client/main.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/client/main.c b/client/main.c
> index 578b3c7c3..0f810901a 100644
> --- a/client/main.c
> +++ b/client/main.c
> @@ -800,6 +800,14 @@ static gboolean parse_argument(int argc, char *argv[], const char **arg_table,
>  {
>         const char **opt;
>
> +       if (!strcmp(argv[1], "help")) {
> +               for (opt = arg_table; opt && *opt; opt++) {
> +                       bt_shell_printf("%s\n", *opt);
> +               }
> +               bt_shell_noninteractive_quit(EXIT_SUCCESS);
> +               return FALSE;
> +       }
> +
>         if (!strcmp(argv[1], "on") || !strcmp(argv[1], "yes")) {
>                 *value = TRUE;
>                 if (option)
> --
> 2.22.1
>


-- 
Luiz Augusto von Dentz