Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: Carey Sonsino <csonsino@gmail.com>
To:     Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>
Cc:     Andreas Kemnade <andreas@kemnade.info>,
        Jamie Mccrae <Jamie.Mccrae@lairdconnect.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
From:   Carey Sonsino <csonsino@gmail.com>
Subject: [PATCH 1/1] bluetooth: update default BLE connection interval bounds
Message-ID: <1c707bb9-999b-7ca3-3c91-7b183dacfdd5@gmail.com>
Date:   Tue, 20 Aug 2019 11:01:41 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Update the default BLE connection interval min/max bounds to the full 
range of permitted values (6-3200, corresponding to 7.25-4000ms).

Commit c49a8682fc5d298d44e8d911f4fa14690ea9485e introduced a bounds 
check on connection interval update requests, but the default min/max 
values were left at 24-40 (30-50ms) which caused problems for devices 
that want to negotiate connection intervals outside of those bounds.

Setting the default min/max connection interval to the full allowable 
range in the bluetooth specification restores the default Linux behavior 
of allowing remote devices to negotiate their desired connection 
interval, while still permitting the system administrator to later 
narrow the range.

Fixes c49a8682fc5d: (validate BLE connection interval updates)

Signed-off-by: Carey Sonsino <csonsino@gmail.com>

---

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 04bc79359a17..f4f2f712c527 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -3181,8 +3181,8 @@ struct hci_dev *hci_alloc_dev(void)
      hdev->le_adv_max_interval = 0x0800;
      hdev->le_scan_interval = 0x0060;
      hdev->le_scan_window = 0x0030;
-    hdev->le_conn_min_interval = 0x0018;
-    hdev->le_conn_max_interval = 0x0028;
+    hdev->le_conn_min_interval = 0x0006;
+    hdev->le_conn_max_interval = 0x0c80;
      hdev->le_conn_latency = 0x0000;
      hdev->le_supv_timeout = 0x002a;
      hdev->le_def_tx_len = 0x001b;