Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH 1/1] bluetooth: update default BLE connection interval
 bounds
From:   Johan Hedberg <johan.hedberg@gmail.com>
In-Reply-To: <1c707bb9-999b-7ca3-3c91-7b183dacfdd5@gmail.com>
Date:   Fri, 23 Aug 2019 13:52:49 +0300
Cc:     Andreas Kemnade <andreas@kemnade.info>,
        Jamie Mccrae <Jamie.Mccrae@lairdconnect.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <A298FF01-96F0-40B2-9124-3B925C960574@gmail.com>
References: <1c707bb9-999b-7ca3-3c91-7b183dacfdd5@gmail.com>
To:     Carey Sonsino <csonsino@gmail.com>,
        Marcel Holtmann <marcel@holtmann.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi,

On 20 Aug 2019, at 20.01, Carey Sonsino <csonsino@gmail.com> wrote:
>=20
> Update the default BLE connection interval min/max bounds to the full =
range of permitted values (6-3200, corresponding to 7.25-4000ms).
>=20
> Commit c49a8682fc5d298d44e8d911f4fa14690ea9485e introduced a bounds =
check on connection interval update requests, but the default min/max =
values were left at 24-40 (30-50ms) which caused problems for devices =
that want to negotiate connection intervals outside of those bounds.
>=20
> Setting the default min/max connection interval to the full allowable =
range in the bluetooth specification restores the default Linux behavior =
of allowing remote devices to negotiate their desired connection =
interval, while still permitting the system administrator to later =
narrow the range.
>=20
> Fixes c49a8682fc5d: (validate BLE connection interval updates)
>=20
> Signed-off-by: Carey Sonsino <csonsino@gmail.com>
>=20
> ---
>=20
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index 04bc79359a17..f4f2f712c527 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -3181,8 +3181,8 @@ struct hci_dev *hci_alloc_dev(void)
>      hdev->le_adv_max_interval =3D 0x0800;
>      hdev->le_scan_interval =3D 0x0060;
>      hdev->le_scan_window =3D 0x0030;
> -    hdev->le_conn_min_interval =3D 0x0018;
> -    hdev->le_conn_max_interval =3D 0x0028;
> +    hdev->le_conn_min_interval =3D 0x0006;
> +    hdev->le_conn_max_interval =3D 0x0c80;
>      hdev->le_conn_latency =3D 0x0000;
>      hdev->le_supv_timeout =3D 0x002a;
>      hdev->le_def_tx_len =3D 0x001b;

This looks fine to me, except the commit message line lengths need =
fixing (max 72-74 or so). It seems we=E2=80=99d want this through the =
Bluetooth stable tree, i.e. still into the 5.3-rc series, correct? =
Marcel, do you agree?

Johan