Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1828649ybn; Thu, 26 Sep 2019 02:52:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqwRuDizH0/Y7C8zRlFgv5fbeqxJVAacvub8cA8iOAhgfoIZn4wgrRSVCDuR+PE4P8lbKP1m X-Received: by 2002:a17:906:4e8f:: with SMTP id v15mr2309358eju.57.1569491539944; Thu, 26 Sep 2019 02:52:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569491539; cv=none; d=google.com; s=arc-20160816; b=LtaYf1E06PKlTsyARpkhhvlp6XD0i/HBNbueTZlzxLJu+WqhsrH2CrmZLzdSZCDzVf xH8uUV3zcsqLUPW0fIjQ7f1UTndPpiiXyFJF2CPa74Fbg28BNyjARbzoTk+KZNjVrZOZ 5f+kylRAXT2T7fnEqge8F7ogKY5Q2Pe3Q5hCqJ9MM5jVvIZQA4HHsnhe6YvGehxjgBGm TMRhjmuSZdwjTKBBMM0+3a64+LXyNLO3uw9ZvDEPaOaYvs5dobgtl1SQnoLIvAA6J73p A/43S4kyxqSBO9BNQ7c1Iht/cM3yIju2apFToGwMhpqjBbON1jX6Ymopomoez/lqfGAc 02lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:to:from; bh=kvxn/s3iabAK5ZssWb3ENGaZFgvP+cD+XiCwhwKZs0w=; b=FSSZ4hx9sNuMWpw4SC8rQWnLOYOWuc4GMUl1vQa4/0IdBJHn6tRQYiyjR9LLCl73Nw UuxqMMYUEHncDxkXUJ4c2VUGINdvD2xVaq9o3jmusvANuz5jIXrFfE7Ug8BrwrxQqO5U TCSYB0kLNdrQtKGkLRXOIHB2/lt0F+oZpUJM4yUqIjJfADXw1SkXQWnZm1F+lD4EnhS6 wx5UI+yp6+mvb4M7Vum3sBKnYJ2JZufcC3tOJh4Qq4WijqyjLSPUq23ydYLPFfgAJ+7/ HNZ/Ycdp1T7LgcYbhe21ExC3coKBCnMjcdW7PVpXBN0LisgQxBil2EOA/F+Xf0Y9VbLr VmNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a30si1019112eda.39.2019.09.26.02.51.54; Thu, 26 Sep 2019 02:52:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730583AbfIYTCV (ORCPT + 99 others); Wed, 25 Sep 2019 15:02:21 -0400 Received: from mga02.intel.com ([134.134.136.20]:8425 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726741AbfIYTCV (ORCPT ); Wed, 25 Sep 2019 15:02:21 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 12:02:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,549,1559545200"; d="p7s'?scan'208";a="273063285" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga001.jf.intel.com with ESMTP; 25 Sep 2019 12:02:20 -0700 Received: from orsmsx153.amr.corp.intel.com (10.22.226.247) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 12:02:20 -0700 Received: from orsmsx103.amr.corp.intel.com ([169.254.5.5]) by ORSMSX153.amr.corp.intel.com ([169.254.12.237]) with mapi id 14.03.0439.000; Wed, 25 Sep 2019 12:02:19 -0700 From: "Stotland, Inga" To: "michal.lowas-rzechonek@silvair.com" , "linux-bluetooth@vger.kernel.org" , "Gix, Brian" , "simon@silvair.com" , "piotr.winiarczyk@silvair.com" Subject: Re: mesh: org.bluez.mesh.Element.MessageReceived method does not provide destination address Thread-Topic: mesh: org.bluez.mesh.Element.MessageReceived method does not provide destination address Thread-Index: AQHVX2LEtJoH6czNyE6Xu9DaIe4hzqcxs2yAgAuqpwA= Date: Wed, 25 Sep 2019 19:02:19 +0000 Message-ID: <3c5858c94b3e08a61c5ff8493f9b00f5f77d0aac.camel@intel.com> References: <20190830184301.zd3zaqrw7mv6r252@kynes> <20190918085239.xhahxoeqjkcrk3bl@mlowasrzechonek2133> In-Reply-To: <20190918085239.xhahxoeqjkcrk3bl@mlowasrzechonek2133> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.254.12.163] Content-Type: multipart/signed; micalg=sha-1; protocol="application/x-pkcs7-signature"; boundary="=-0tYzmf4BE3oYFUpYV34G" MIME-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org --=-0tYzmf4BE3oYFUpYV34G Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Michal, On Wed, 2019-09-18 at 10:52 +0200, Micha=C5=82 Lowas-Rzechonek wrote: > Hi Brian, >=20 > > Imagine a dot-matrix, where each pixel is a mesh node. > >=20 > > Each of these pixels implements two models: > > on element 0, a GenericOnOffServer controlling the light output > > on element 1, a Blinkenlights Server model > >=20 > > Blinkenlights Server extends GenericOnOff Server and GenericOnOff > > Client, and on top of that contains a translation table mapping > > group > > address to either 'ON' or 'OFF'. > >=20 > > Now, when Blinkenlights Server receives a GenericOnOff Set message, > > it > > looks up the destination address at the translation table, and > > sends a > > *different* GenericOnOff Set to *its own* element 0, with target > > value > > determined by the translation entry. > >=20 > > This allows users to configure each node in such a way, that > > sending a > > *single* message to a group address causes all pixels to switch to > > a > > preconfigured pattern *at the same time*. >=20 > Per conversation with Piotr, I'd like to revisit the discussion and > provide more details about our use case for models knowing the > destination address. >=20 > Please see a diagram at http://ujeb.se/BmTIW. >=20 > The main reason we map scenes using destination addresses is that > such a > setup consumes much less unicast addresses. >=20 > Assuming that: > S - number of switches > B - number of buttons (elements) on a switch > N - nunber of lamps >=20 > With a 'regular' case, number of consumed unicast addresses is > S*B + N*(B+1) >=20 > With the destination mapping, it becomes > S*B + N*2 >=20 > Since we typically use 4 button switches (B=3D4), without translation > we > consume unicast address space at a *much* faster rate. >=20 > reagrds Okay, this is a good argument for exposing the subscription address in MessageReceived(). It's better to separate the method into two, e.g. MessageReceived() and MessageReceivedVirtual(). Then it makes sense to add model subscription array as a dictionary entry in the UpdateModelConfiguration() as well as for the node configuration returned when calling Attach() method. Probably will have to have separate keys: "Groups" and "Virtuals". Regards, Inga --=-0tYzmf4BE3oYFUpYV34G Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKbDCCBOsw ggPToAMCAQICEDabxALowUBS+21KC0JI8fcwDQYJKoZIhvcNAQEFBQAwbzELMAkGA1UEBhMCU0Ux FDASBgNVBAoTC0FkZFRydXN0IEFCMSYwJAYDVQQLEx1BZGRUcnVzdCBFeHRlcm5hbCBUVFAgTmV0 d29yazEiMCAGA1UEAxMZQWRkVHJ1c3QgRXh0ZXJuYWwgQ0EgUm9vdDAeFw0xMzEyMTEwMDAwMDBa Fw0yMDA1MzAxMDQ4MzhaMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIGA1UEBxMLU2Fu dGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQDEyJJbnRlbCBFeHRl cm5hbCBCYXNpYyBJc3N1aW5nIENBIDRCMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA yzuW/y/g0bznz8BD48M94luFzqHaqY9yGN9H/W0J7hOVBpl0rTQJ6kZ7z7hyDb9kf2UW4ZU25alC i+q5m6NwHg+z9pcN7bQ84SSBueaYF7cXlAg7z3XyZbzSEYP7raeuWRf5fYvYzq8/uI7VNR8o/43w PtDP10YDdO/0J5xrHxnC/9/aU+wTFSVsPqxsd7C58mnu7G4VRJ0n9PG4SfmYNC0h/5fLWuOWhxAv 6MuiK7MmvTPHLMclULgJqVSqG1MbBs0FbzoRHne4Cx0w6rtzPTrzo+bTRqhruaU18lQkzBk6OnyJ UthtaDQIlfyGy2IlZ5F6QEyjItbdKcHHdjBX8wIDAQABo4IBdzCCAXMwHwYDVR0jBBgwFoAUrb2Y ejS0Jvf6xCZU7wO94CTLVBowHQYDVR0OBBYEFNpBI5xaj3GvV4M+INPjZdsMywvbMA4GA1UdDwEB /wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMDYGA1UdJQQvMC0GCCsGAQUFBwMEBgorBgEEAYI3 CgMEBgorBgEEAYI3CgMMBgkrBgEEAYI3FQUwFwYDVR0gBBAwDjAMBgoqhkiG+E0BBQFpMEkGA1Ud HwRCMEAwPqA8oDqGOGh0dHA6Ly9jcmwudHJ1c3QtcHJvdmlkZXIuY29tL0FkZFRydXN0RXh0ZXJu YWxDQVJvb3QuY3JsMDoGCCsGAQUFBwEBBC4wLDAqBggrBgEFBQcwAYYeaHR0cDovL29jc3AudHJ1 c3QtcHJvdmlkZXIuY29tMDUGA1UdHgQuMCygKjALgQlpbnRlbC5jb20wG6AZBgorBgEEAYI3FAID oAsMCWludGVsLmNvbTANBgkqhkiG9w0BAQUFAAOCAQEAp9XGgH85hk/3IuN8F4nrFd24MAoau7Uq M/of09XtyYg2dV0TIPqtxPZw4813r78WwsGIbvtO8VQ18dNktIxaq6+ym2zebqDh0z6Bvo63jKE/ HMj8oNV3ovnuo+7rGpCppcda4iVBG2CetB3WXbUVr82EzECN+wxmC4H9Rup+gn+t+qeBTaXulQfV TYOvZ0eZPO+DyC2pVv5q5+xHljyUsVqpzsw89utuO8ZYaMsQGBRuFGOncRLEOhCtehy5B5aCI571 i4dDAv9LPODrEzm3PBfrNhlp8C0skak15VXWFzNuHd00AsxXxWSUT4TG8RiAH61Ua5GXsP1BIZwl 4WjK8DCCBXkwggRhoAMCAQICEzMAAHkSbxmcZYXZ3q8AAAAAeRIwDQYJKoZIhvcNAQEFBQAweTEL MAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQwEgYDVQQHEwtTYW50YSBDbGFyYTEaMBgGA1UEChMR SW50ZWwgQ29ycG9yYXRpb24xKzApBgNVBAMTIkludGVsIEV4dGVybmFsIEJhc2ljIElzc3Vpbmcg Q0EgNEIwHhcNMTkwMzI4MTgzOTA4WhcNMjAwMzIyMTgzOTA4WjBBMRcwFQYDVQQDEw5TdG90bGFu ZCwgSW5nYTEmMCQGCSqGSIb3DQEJARYXaW5nYS5zdG90bGFuZEBpbnRlbC5jb20wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQC2G5M/W8NZAZ4TJB1BMvVCtoUmCavUkUo2lw8xY/EZcyre fgklUGbk5bVeALgRgWOy/STHNpXu+LxzDICt0uPhoVrpz3WPF8akFdIve4IYMZJ3vkFOeiclseLw Yqg3zQTabz5Z1XMx/iq2MJmC8MUdrovdLGNacPM6+dJWVsslFOBO3vuSaypGKXmKdy8vfSIXX6vK f5VlWW2Gi3WRHfuyuWtnEJbkoPLtydTNvBzqLpe8QmcM5wXio8/mZfnPDDWR8I1FO8MWzQF6rG00 k3sf6w6ZKbZbz2V54rncMEXM3N/P4C6ZHZR0XYqh5m1vWxZYYVzTuDEH1C8W+b3KzldrAgMBAAGj ggIwMIICLDAdBgNVHQ4EFgQUcdzZH9M8OSxLujP+AToiD5oYMRkwHwYDVR0jBBgwFoAU2kEjnFqP ca9Xgz4g0+Nl2wzLC9swZQYDVR0fBF4wXDBaoFigVoZUaHR0cDovL3d3dy5pbnRlbC5jb20vcmVw b3NpdG9yeS9DUkwvSW50ZWwlMjBFeHRlcm5hbCUyMEJhc2ljJTIwSXNzdWluZyUyMENBJTIwNEIu Y3JsMIGeBggrBgEFBQcBAQSBkTCBjjAhBggrBgEFBQcwAYYVaHR0cDovL29jc3AuaW50ZWwuY29t MGkGCCsGAQUFBzAChl1odHRwOi8vd3d3LmludGVsLmNvbS9yZXBvc2l0b3J5L2NlcnRpZmljYXRl cy9JbnRlbCUyMEV4dGVybmFsJTIwQmFzaWMlMjBJc3N1aW5nJTIwQ0ElMjA0Qi5jcnQwCwYDVR0P BAQDAgeAMDwGCSsGAQQBgjcVBwQvMC0GJSsGAQQBgjcVCIbDjHWEmeVRg/2BKIWOn1OCkcAJZ4He vTmV8EMCAWQCAQkwHwYDVR0lBBgwFgYIKwYBBQUHAwQGCisGAQQBgjcKAwwwKQYJKwYBBAGCNxUK BBwwGjAKBggrBgEFBQcDBDAMBgorBgEEAYI3CgMMMEsGA1UdEQREMEKgJwYKKwYBBAGCNxQCA6AZ DBdpbmdhLnN0b3RsYW5kQGludGVsLmNvbYEXaW5nYS5zdG90bGFuZEBpbnRlbC5jb20wDQYJKoZI hvcNAQEFBQADggEBALnl11xd+3X6fVS0VAKeoF0jCPLFZLCk4jMFifFzY2md3MLjVIB3lE5ffNnS mjG9ErOO6as95K6D6hzCJMqNodOyVPRSrMNey0tzFAPLRG3s2bgfmOcvYr4O3WmpDMx8YmH6O2YI 3Xxjyp11aXl5pk6VjpZV/hjN1jwZ/c/X00KsjoMB8mGSBvbwnV0EFQUJ99xsAlqQ4edj2T9z6pF1 WX189YL64c/t3a9LWNaT2CWbBZLIFoor9TpZsIj0lGObmGA76JKn5yxN+jzxhWIAzPi5KKYgJ9EU FDn6fGbJHisZdWX3bVamfpmPogThm1khlD7R4USu0eyym3JRh0tXJeAxggIXMIICEwIBATCBkDB5 MQswCQYDVQQGEwJVUzELMAkGA1UECBMCQ0ExFDASBgNVBAcTC1NhbnRhIENsYXJhMRowGAYDVQQK ExFJbnRlbCBDb3Jwb3JhdGlvbjErMCkGA1UEAxMiSW50ZWwgRXh0ZXJuYWwgQmFzaWMgSXNzdWlu ZyBDQSA0QgITMwAAeRJvGZxlhdnerwAAAAB5EjAJBgUrDgMCGgUAoF0wGAYJKoZIhvcNAQkDMQsG CSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMTkwOTI1MTkwMjE4WjAjBgkqhkiG9w0BCQQxFgQU u+S9emfMPt/2wM6640uHn5KrTd0wDQYJKoZIhvcNAQEBBQAEggEAquhCW+x2ALgXu+8XbMBPAtzB mCS5dqXwpuKavfZ7ByzTdi2QhYiJbEFDTfEYT8wbGY35LCHwRf4dMQNJpQYAu6NISywjR0ESWoMf qzKXvTunrTX8H560wpqn2D6WgWUcAb4XHyP/84wblE+GQGSIrn2nmYp0mXLpb1aNWu8iPh/iBHUg YPRU6QvsrvKvoH3shFyYhc2SCYA+Mzb73pWdPDYcs2a47F04MdsMVe7jkvi7Cwfu4znYsyvXghSI 6NdPOGyfPzIvI9mm/nHLkSmX1IMdgtet5XkLQjweAjnIlW1kh3BbUu5BB2Qyj0modv4Y8GTZ7d/5 7Wx/cdWm01sQbAAAAAAAAA== --=-0tYzmf4BE3oYFUpYV34G--