Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Bag, Amit K" <amit.k.bag@intel.com>
To:     Marcel Holtmann <marcel@holtmann.org>
CC:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
        "Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>
Subject: RE: [PATCH] Bluetooth: btusb: print FW version after FW download
Thread-Topic: [PATCH] Bluetooth: btusb: print FW version after FW download
Thread-Index: AQHVc4lfO5YrBKLIykCNmu1lbaKwrKc8+TYAgAHbOqA=
Date:   Fri, 27 Sep 2019 02:49:53 +0000
Message-ID: <EFE6F46E14A5F445949D76A8CAC224005844D80D@PGSMSX105.gar.corp.intel.com>
References: <1569405826-4555-1-git-send-email-amit.k.bag@intel.com>
 <EB27BBF5-DB98-4C67-904B-6EA11C800008@holtmann.org>
In-Reply-To: <EB27BBF5-DB98-4C67-904B-6EA11C800008@holtmann.org>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

>Hi Amit,
>
>> After FW download there is no print to confirm the current FW version. 
>> Add print to check FW version incase of FW download.
>> 
>> Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
>> ---
>> drivers/bluetooth/btusb.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>> 
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c 
>> index a9c35ebb30f8..f6c033b5042c 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -2432,6 +2432,14 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
>> 	 */
>> 	btintel_set_event_mask(hdev, false);
>> 
>> +	/* Read the Intel version information after loading the FW  */
>> +	err = btintel_read_version(hdev, &ver);
>> +	if (err)
>> +		return err;
>> +
>> +	btintel_version_info(hdev, &ver);
>> +	bt_dev_info(hdev, "Setup complete");
>> +
>
>I rather not add an extra Setup complete since that is rather noisy. We can add the extra version information if that adds value.
>

I will remove this message and post the revised patch.