Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190811070045.15406-1-inga.stotland@intel.com> <fb9e9c39bf24900c84bd7fe63d91c8443895ee3e.camel@intel.com>
In-Reply-To: <fb9e9c39bf24900c84bd7fe63d91c8443895ee3e.camel@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 27 Sep 2019 17:38:49 +0300
Message-ID: <CABBYNZ+Jdh1CSZZXs9asUdF6GUc-18QZzxgt6d74szQ8SvTSpQ@mail.gmail.com>
Subject: Re: [PATCH BlueZ 0/1 v3] ELL based mainloop
To:     "Stotland, Inga" <inga.stotland@intel.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "johan.hedberg@gmail.com" <johan.hedberg@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Inga,

On Wed, Sep 25, 2019 at 9:19 PM Stotland, Inga <inga.stotland@intel.com> wrote:
>
> Ping
>
> On Sun, 2019-08-11 at 00:00 -0700, Inga Stotland wrote:
> > + timeout-ell.c
> >
> > This patch addresses a need to enable using common mainloop for the
> > ell-based apps that desire to use common bluetooth fuctionality
> > (e.g., bt_shell).
> >
> > Note: A bit awkward callback handling there is due to the discrepancy
> > in the arg type for signo (signal number).
> >
> > src/shared/mainloop.h:
> > typedef void (*mainloop_signal_func) (int signum, void *user_data)
> >
> > and ell/main.h:
> >
> > typedef void (*l_main_signal_cb_t) (uint32_t signo, void *user_data)
> >
> > My guess is that ell derives the unsigned int type from
> > <sys/signalfd.h>,
> > where ssi_signo is defined as uint32_t. BlueZ is probably following
> > the
> > standard Linux signal handling, where signal is represented as an
> > int.
> >
> > Inga Stotland (1):
> >   shared/mainloop: Add ell-based mainloop implementation
> >
> >  Makefile.am               |  11 +++-
> >  src/shared/mainloop-ell.c | 126
> > ++++++++++++++++++++++++++++++++++++++
> >  src/shared/timeout-ell.c  |  72 ++++++++++++++++++++++
> >  3 files changed, 206 insertions(+), 3 deletions(-)
> >  create mode 100644 src/shared/mainloop-ell.c
> >  create mode 100644 src/shared/timeout-ell.c
> >

Applied, thanks.

-- 
Luiz Augusto von Dentz