Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp6791551ybn; Mon, 30 Sep 2019 03:57:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyvUHBp4qHT0SEu6JoMIs9ikXk6BTft2OVI4Po13rRCxg33tRpCKxIESLhRBR2LC7Cp2MTE X-Received: by 2002:a17:906:6445:: with SMTP id l5mr18622638ejn.12.1569841065002; Mon, 30 Sep 2019 03:57:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569841064; cv=none; d=google.com; s=arc-20160816; b=YHET7DM+zVY0tCS2v2i4KD7nj7bQhB6giGhq26mp2/yN0BtoVRoIvIfl0i5CjbhXWv 2GZiP6ClnQ5Sxr1SB5RJtuu9qY5g506C5+BAbEZbK3jpUR0c4XirBYiKsMytBMRgsJGK YaWXpqYkYFcVQGgNTHWmlQ0WDec9AH2hBsgr46TmXzhD+a78F3YHdUjei5Hvd7hUqPWn 6wJuPcq0/jRNjdoUk9v8cCH9Lj1jEV+1NWhnrp8AHA2H+lcCEnomIFyG/7l4ix1SsxSg mJxq68z7DQuHkD7u9ULwSkNkmAOE71nPFKsck2+vnTdrgGSTyaqx9zgQ5icHxPrqmVox nsfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=YP7LM/RmWQL82An/EdW4oyV4KLY+KNCzsOSBjn3AnAQ=; b=a9faG5hIm1s1Vqm06yaIwVEJ/nsenE2zfmxpd+bN84I7ojikUuBhPCw3YNnB8FlSKx LxNWpNWNCX7rHIHgfAqX/IAGttDODIuvQo31JIIZ76bjZdM5tecIfjGVlWFk9IrXc9lG XxkWH3wo9rkSLVMSW4qJF7nJNgdXIzneILSqDpQvGYvZCOgTKniyr3UZV/dzmnH93J4m hqBbrq7f0ubHDPyPF02Tsu8un5j0suRiX2f0W5eHp266XosFMC/ybUDdv6GX4g5agKtI 4ISiBmwSU4RaR/Glk5ganm0ZwVZ2hZonfoH5j8Pbl5emXnuPLj+unU0OXdufgd1fnGxk LaJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=j6EFCJd5; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10si6854001ejc.337.2019.09.30.03.57.12; Mon, 30 Sep 2019 03:57:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=j6EFCJd5; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730383AbfI3Kyi (ORCPT + 99 others); Mon, 30 Sep 2019 06:54:38 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39557 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730345AbfI3Kyi (ORCPT ); Mon, 30 Sep 2019 06:54:38 -0400 Received: by mail-pf1-f195.google.com with SMTP id v4so5389032pff.6 for ; Mon, 30 Sep 2019 03:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YP7LM/RmWQL82An/EdW4oyV4KLY+KNCzsOSBjn3AnAQ=; b=j6EFCJd5c3KTmERJ0y6boOJxdGPvXLMunQe3Imx4V0PfswVmHhBgWoG0VfF83WKWMQ 2sURmJa8xW03MeIJYNQ3zMC9XF0IuGil/azBD/F1X4h+QjYK3Q2V16XsMBM2AMmWUZQg QvysLLWaUIpn8d4GlhTUF3jLyzLzR91KC4Pu5vN6nnivs8SgGw7cVMofXxex5AcTEZsG 2rStfahfH4mFmKR9JaxCJEbsBeRtaxhU4h7mIZSdP2EQmM7/zI1RLPJUqvYQeb1GWyI/ 2CiWytMjZ+Pl4z4OWY4YmcsM9lkov40L12C/a2yuKi+tXiNDcEr8YyjMfFjC3R4VmN6s uihw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=YP7LM/RmWQL82An/EdW4oyV4KLY+KNCzsOSBjn3AnAQ=; b=J1/msb0QzkRLyVKAfKl2oBJYkGPqon7OJsR15cUceOCU/zNzlFHv7wDnNedNWuJXJW dRJksPBFdL4mBGT+l3VdcCJ5fqJBzMi/hkk2xtxWPvOgxsaaiJWHLQMZtK12q8oZg81G Gw7NeGCwGHLsDeDC7C0mhD2JAkwoDmzj2+4f4fbRjzxsKXqlodaLZE9+3y3+AZpMLKbR 4mNmu3Ky2/OAFAJ1g2K7lcTbfX2itKnC77V2Ur5mpgQfDCbZg9cL5fbYonwdBIwZ8wvW CjExMuP7Iyfe9ccJIr4JAbD3YIaFAZnCZSq9sFXnpjEJ0ryOKYFShg5GZpnj+WSxu5tD wH8Q== X-Gm-Message-State: APjAAAUlif/y6jtho/lt8AFgyd7PBBJshnA6ngi0kVE6D1BnEta9114o jUvS+cBaVwS7HZcg/48QVoVXyVMST0UImQ== X-Received: by 2002:a17:90a:a78d:: with SMTP id f13mr25830498pjq.18.1569840877403; Mon, 30 Sep 2019 03:54:37 -0700 (PDT) Received: from localhost ([192.55.54.40]) by smtp.gmail.com with ESMTPSA id r21sm15699887pgm.78.2019.09.30.03.54.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Sep 2019 03:54:36 -0700 (PDT) Date: Mon, 30 Sep 2019 13:54:33 +0300 From: Johan Hedberg To: Marcel Holtmann Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] Bluetooth: btusb: Use IS_ENABLED instead of #ifdef Message-ID: <20190930105433.GA52240@jhedberg-mac01.fi.intel.com> Mail-Followup-To: Marcel Holtmann , linux-bluetooth@vger.kernel.org References: <20190927064858.121461-1-marcel@holtmann.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190927064858.121461-1-marcel@holtmann.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Marcel, On Fri, Sep 27, 2019, Marcel Holtmann wrote: > For the different hardware support options, it is better to use > IS_ENABLED check. Let the compiler do the needed optimizations. > > Signed-off-by: Marcel Holtmann > --- > drivers/bluetooth/btusb.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) Applied to bluetooth-next. Thanks. Johan