Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190721155522.3vqt7vsprhpxflqf@pali> <CABBYNZK6cuz9n4Hu9uRCbQvn9uFEYkn9=mY8J5Fqu0u-D3B1EA@mail.gmail.com>
 <20190829125734.GH2840@reaktio.net> <20190829200513.6xnta5jx3trbmgxp@pali>
 <20191003181855.GF28704@reaktio.net> <20191006100503.fsbttcschr6wgsdq@pali>
 <CABBYNZLS4MMxJ=gQED-BVfn81D0bvx8aLw5OO3tNmXAnWeA57Q@mail.gmail.com>
 <20191006120245.tkrooh45q7irtm6l@pali> <20191007143307.ez6g466afu3trlxn@pali>
 <CABBYNZ+2CGn2rONg+Tpdh9vr7E40_SFFT4Mmru2vQw7MKHTFjQ@mail.gmail.com> <20191008103333.rqn2btlkwtcrpouo@pali>
In-Reply-To: <20191008103333.rqn2btlkwtcrpouo@pali>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 9 Oct 2019 16:15:59 +0300
Message-ID: <CABBYNZKKUf6-FPBEGjuC5GbsNzNsDLy7LgCHxqiW_g98BaX+QA@mail.gmail.com>
Subject: Re: [PATCH BlueZ 1/4] doc/media-api: Add RegisterApplication method
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc:     =?UTF-8?B?UGFzaSBLw6Rya2vDpGluZW4=?= <pasik@iki.fi>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Pali,

On Tue, Oct 8, 2019 at 1:33 PM Pali Roh=C3=A1r <pali.rohar@gmail.com> wrote=
:
>
> On Tuesday 08 October 2019 13:28:53 Luiz Augusto von Dentz wrote:
> > Hi Pali,
> >
> > On Mon, Oct 7, 2019 at 5:33 PM Pali Roh=C3=A1r <pali.rohar@gmail.com> w=
rote:
> > >
> > > On Sunday 06 October 2019 14:02:45 Pali Roh=C3=A1r wrote:
> > > > On Sunday 06 October 2019 13:53:37 Luiz Augusto von Dentz wrote:
> > > > > Hi Pali,
> > > > >
> > > > > On Sun, Oct 6, 2019 at 1:05 PM Pali Roh=C3=A1r <pali.rohar@gmail.=
com> wrote:
> > > > > >
> > > > > > On Thursday 03 October 2019 21:18:55 Pasi K=C3=A4rkk=C3=A4inen =
wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > On Thu, Aug 29, 2019 at 10:05:13PM +0200, Pali Roh=C3=A1r wro=
te:
> > > > > > > > On Thursday 29 August 2019 15:57:34 Pasi K=C3=A4rkk=C3=A4in=
en wrote:
> > > > > > > > > Pali: How does it look with porting the PA patches to use=
 the new interfaces?
> > > > > > > >
> > > > > > > > Hello, I have not had a time yet to play with these pulseau=
dio patches
> > > > > > > > and porting to the new interface. I guess that I could have=
 more free
> > > > > > > > time in the last week of next month.
> > > > > > > >
> > > > > > >
> > > > > > > It seems BlueZ 5.51 has been released meanwhile (http://www.b=
luez.org/release-of-bluez-5-51/)
> > > > > > > So now at least the new interfaces are in a released bluez ve=
rsion.
> > > > > >
> > > > > > Ok! Today I have looked at this new Bluez API, but seems that t=
here is
> > > > > > not only missing some examples or usages with libdbus-1, but al=
so
> > > > > > documentation. I have tried to find something how to register e=
ndpoints
> > > > > > throw GetManagedObjects() via libdbus-1, but seems that there i=
s no
> > > > > > usage of it and also unusable documentation for it in libdbus-1=
. So
> > > > > > currently I'm stuck how to use this exotic API in pulseaudio...
> > > > >
> > > > > It is just another D-Bus method, the only difference is that it
> > > > > carries the entire object tree, btw I did add an example of how t=
o
> > > > > register Endpoints in python:
> > > > >
> > > > > https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/test/exam=
ple-endpoint
> > > >
> > > > This example uses undocumented property "DelayReporting". What it i=
s doing?
> > >
> > > Also this new Managed Objects API bring some inconsistency. Codec
> > > switching API is available only when bluetoothd was started with
> > > --experimental flag, but this new Object API is available also withou=
t
> > > it. So it just complicated implementation.
> > >
> > > How could application (e.g. pulseaudio) check if A2DP codec switching=
 is
> > > available and based on this decide if via Managed Objects API export
> > > more codecs or just only default SBC?
> >
> > The idea was that this API would be experimental as well but it seems
> > it is not,
>
> No, it is not experimental. Managed Objects API is available also when
> bluetoothd is started without --experimental argument.
>
> > they should go hand in hand with Endpoint objects to ensure
> > they will be available as well so we might have to fix this in 5.52,
> > too bad we didn't see this before 5.51 went out.
>
> So... what should applications expects and how they should implement
> above decision?

Actually the decision should be based on the presence of
RegisterApplication method, if that exists then endpoint switching
should be supported as well, so has nothing to do the
GetManagedObjects API of the bluetoothd. That said RegisterApplication
was not made experimental which kind makes 5.51 broken because it
would appear that it endpoint objects would be exposed but when in
fact there are not, anyway lets finally have the code to use this
interface and then we can remove the experimental flag from
MediaEndpoint.

> > > > > You can also have a look at how our gdbus internal library (uses
> > > > > libdbus) utilize it:
> > > > >
> > > > > https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/gdbus/cli=
ent.c#n1269
> > > > >
> > > >
> > >
> > > --
> > > Pali Roh=C3=A1r
> > > pali.rohar@gmail.com
> >
> >
> >
>
> --
> Pali Roh=C3=A1r
> pali.rohar@gmail.com


--=20
Luiz Augusto von Dentz