Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3594.4.19\))
Subject: Re: [PATCH] Bluetooth: Workaround hd directed advertising bug in
 Broadcom controllers
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20191002122243.31519-1-szymon.janc@codecoup.pl>
Date:   Wed, 16 Oct 2019 21:17:54 +0200
Cc:     linux-bluetooth@vger.kernel.org,
        =?utf-8?Q?S=C3=B6ren_Beye?= <linux@hypfer.de>
Content-Transfer-Encoding: 8BIT
Message-Id: <6C0D0A41-21F4-45CF-B21C-ED9A46A989C6@holtmann.org>
References: <20191002122243.31519-1-szymon.janc@codecoup.pl>
To:     Szymon Janc <szymon.janc@codecoup.pl>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Szymon,

> It appears that some Broadcom controllers (eg BCM20702A0) reject LE Set
> Advertising Parameters command if advertising intervals provided are not
> within range for undirected and low duty directed advertising.
> 
> Workaround this bug by populating min and max intervals with 'valid'
> values.
> 
> < HCI Command: LE Set Advertising Parameters (0x08|0x0006) plen 15                                                                                                                                                                                                                                      #75 [hci0] 29.155775
>        Min advertising interval: 0.000 msec (0x0000)
>        Max advertising interval: 0.000 msec (0x0000)
>        Type: Connectable directed - ADV_DIRECT_IND (high duty cycle) (0x01)
>        Own address type: Public (0x00)
>        Direct address type: Random (0x01)
>        Direct address: E2:F0:7B:9F:DC:F4 (Static)
>        Channel map: 37, 38, 39 (0x07)
>        Filter policy: Allow Scan Request from Any, Allow Connect Request from Any (0x00)
>> HCI Event: Command Complete (0x0e) plen 4                                                                                                                                                                                                                                                             #76 [hci0] 29.156745
>      LE Set Advertising Parameters (0x08|0x0006) ncmd 1
>        Status: Invalid HCI Command Parameters (0x12)
> 
> Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl>
> Tested-by: Sören Beye <linux@hypfer.de>
> ---
> net/bluetooth/hci_conn.c | 8 ++++++++
> 1 file changed, 8 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel