Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191009085116.199922-1-tientzu@chromium.org> <238f01ec4b49fee4c0d08a0b8da7e95f@codeaurora.org>
 <74740c0ff64a6a658da2a44a9f9b7ac5@codeaurora.org>
In-Reply-To: <74740c0ff64a6a658da2a44a9f9b7ac5@codeaurora.org>
From:   Claire Chang <tientzu@chromium.org>
Date:   Fri, 18 Oct 2019 10:59:54 +0800
Message-ID: <CALiNf2_EcJxxTYd52UVyaJ-Q82YPM5MKTPBmMNUrBZryEShwqw@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: hci_qca: fix in-band sleep enablement
To:     Balakrishna Godavarthi <bgodavar@codeaurora.org>
Cc:     Harish Bandi <c-hbandi@codeaurora.org>, marcel@holtmann.org,
        johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org,
        lkml <linux-kernel@vger.kernel.org>,
        Rocky Liao <rjliao@codeaurora.org>, rongchi@codeaurora.org,
        linux-bluetooth-owner@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Balakrishna,

Sorry for the late reply. I was on vacation for the past few days.
The chipset we use is QCA6174A-3 and rjliao has already confirmed that
IBS won't work without RAM fw downloaded.
Please ignore this change.

Thanks,
Claire


On Fri, Oct 11, 2019 at 3:21 PM Balakrishna Godavarthi
<bgodavar@codeaurora.org> wrote:
>
> Hi Claire,
>
> This change will not work  as we need fw files to be loaded tofor IBS to
> active.
> may i know on which chipset you have this issue of IBS active even with
> out fw download.
>
> On 2019-10-11 12:31, Harish Bandi wrote:
> > ++ Balakrishna
> >
> > On 2019-10-09 14:21, Claire Chang wrote:
> >> Enabling in-band sleep when there is no patch/nvm-config found and
> >> bluetooth is running with the original fw/config.
> >>
> >> Fixes: ba8f35979002 ("Bluetooth: hci_qca: Avoid setup failure on
> >> missing rampatch")
> >> Fixes: 7dc5fe0814c3 ("Bluetooth: hci_qca: Avoid missing rampatch
> >> failure with userspace fw loader")
> >> Signed-off-by: Claire Chang <tientzu@chromium.org>
> >> ---
> >>  drivers/bluetooth/hci_qca.c | 11 +++++++----
> >>  1 file changed, 7 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> >> index e3164c200eac..367eef893a11 100644
> >> --- a/drivers/bluetooth/hci_qca.c
> >> +++ b/drivers/bluetooth/hci_qca.c
> >> @@ -1291,10 +1291,8 @@ static int qca_setup(struct hci_uart *hu)
> >>      /* Setup patch / NVM configurations */
> >>      ret = qca_uart_setup(hdev, qca_baudrate, soc_type, soc_ver,
> >>                      firmware_name);
> >> -    if (!ret) {
> >> -            set_bit(QCA_IBS_ENABLED, &qca->flags);
> >> -            qca_debugfs_init(hdev);
> >> -    } else if (ret == -ENOENT) {
> >> +
> >> +    if (ret == -ENOENT) {
> >>              /* No patch/nvm-config found, run with original fw/config */
> >>              ret = 0;
> >>      } else if (ret == -EAGAIN) {
> >> @@ -1305,6 +1303,11 @@ static int qca_setup(struct hci_uart *hu)
> >>              ret = 0;
> >>      }
> >>
> >> +    if (!ret) {
> >> +            set_bit(QCA_IBS_ENABLED, &qca->flags);
> >> +            qca_debugfs_init(hdev);
> >> +    }
> >> +
> >>      /* Setup bdaddr */
> >>      if (qca_is_wcn399x(soc_type))
> >>              hu->hdev->set_bdaddr = qca_set_bdaddr;
>
> --
> Regards
> Balakrishna.