Received: by 2002:a25:d7c1:0:0:0:0:0 with SMTP id o184csp1741379ybg; Sat, 19 Oct 2019 01:30:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqwkXfwpAqv/AN6rdzEqsc7gaJTZbrzHTgz8wJFG8Lpo+ORc+ia1gL5CGeN72m7h8TccYyV5 X-Received: by 2002:a17:906:4d5a:: with SMTP id b26mr12484066ejv.157.1571473833624; Sat, 19 Oct 2019 01:30:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571473833; cv=none; d=google.com; s=arc-20160816; b=D3a+dQxHU9CT6MmUINC0DlJF0CRl9wvWandw7R9jWXMQ6Kuzzgm9foRVRV978jdFQ1 XHpwDNrjD9/CP4zIZ5p89et/RILeyCEOfwLABnZYmZ7P/Gm/1mYnDbYwntyQtIUgkllG HeVLQFySC1FX+BZYcWLOdz3vVtmzuRUJ1Gi6d29q/q83oiJSbrgJsQ2qPD9jkt8ZAp5t THYNcMSAa6tVGWj5zGoGYD7V35gWl8nVJytc5pVMtwloHkY3h8YqJSX+1pPiNT9AdETh 8TFexfDD447skxcUP0Ts2PH99XmjRf/dSnFhJIsX03w+Rp8qcs3bBfMHkET23iS4Uf+c NiGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=utSOLik7GjZ8tmaygvRuxaRmMUvN6dgih61xSu5Jmm8=; b=VMyoJWtl8evSJBIR/R13Y5w/PZ3cPVPo8V0OKG1du8KbBBEI8tPjiijmoobalgt59y hXRCPpYwD5dpPBzRMH6XF625VSl//VmY7ISxYx7duhmLi49RVjnoTZqtXvEcWEoNFzJ0 QlNxszihM/pCbwfPFR25y8jH8lYapV2qqnzJnEcrpPqYgH+U6VsZFktNWiuc1Gsn2PPC TJt5ZFenZ8pbmIb9mFkKWWdxEkpfyKzf2xIeD5uSLrKAdU5e4sWorqDhKZbKig9WSD1W 02Ouq5mt86L2OBJByilcRtEGecjdmv2nh/9zmeKHJo+VsQtx0CgoQsprW7Ic8SQn5SgF epAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q9FkMiMV; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w12si5368916edx.223.2019.10.19.01.30.03; Sat, 19 Oct 2019 01:30:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q9FkMiMV; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439563AbfJROw5 (ORCPT + 99 others); Fri, 18 Oct 2019 10:52:57 -0400 Received: from mail-il1-f193.google.com ([209.85.166.193]:35007 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394114AbfJROw5 (ORCPT ); Fri, 18 Oct 2019 10:52:57 -0400 Received: by mail-il1-f193.google.com with SMTP id j9so5803768ilr.2; Fri, 18 Oct 2019 07:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=utSOLik7GjZ8tmaygvRuxaRmMUvN6dgih61xSu5Jmm8=; b=Q9FkMiMVEAJCDWueSjnSLm4tQPO/Wgdi9ZmU82lozZglM5JzA2FleaeSfYEEHGeOmo Zot9oAH1NnjKktG+vjJ+w9xtHNDcCYf3myzEYdC6yoeMDGnA6FRbr587bNeKNbFlZ+8h yoAYxYMBgWqAPgAl73p3QS4LHp0/BoBe15VnFIDntGhjlYCGAbVQ1uuB8BSU2JK7whZ5 i8jc8Amq7ODjcsbg5fIcHM6Ngn/fJ3/CoS3w1UgYOBWNcP6Csggf2WVdQXUclzWhWQAj cyBNJBLt76eOHtEWyIoQ48arr1lAr43g8iA51ug/cRW82JD8lAjBF8JI0/qorQ0t2OZi QsfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=utSOLik7GjZ8tmaygvRuxaRmMUvN6dgih61xSu5Jmm8=; b=lWX8TvoKzQV9bTfgiReq7XVNihB+EoWL4Og3ZbxqXlT+C0ORnfyVOHUSXsD0NZjugu kK7IIKlxdMBXK/7KvqQwWGzSGrjp5ot1jaqxkdHuNpyiwsOsn1YMPctxNij892+8qMbZ 2lajwLv+0rvtAy3xIE90O4jJJ/mc5RWJbkzyXs7DjsgLVrN8czbwGMburoiQmrUQtmF5 3xKd+rJmSmHjvVXMOx7o5G+VJ2Et9Ac6uJYShX9BSCc87aE1Ijnsc1cYUb6qQuMC9wbP WOW7pjGWFfuAp5Rj7wv6mdkSTdeMqQ0VcCXZKSwxVoI5+b7ZLS8HpSKK32e6AiM80F9+ +roA== X-Gm-Message-State: APjAAAUGT6S7/FBP3UVgPIy7W+0qgh/PFU/jwpaM22qzPyHVstp7pNgJ CdjX41wZe64uDAt97XQaFoQYVk6kxTK6NGASDgLbCg== X-Received: by 2002:a05:6e02:783:: with SMTP id q3mr10176592ils.33.1571410374919; Fri, 18 Oct 2019 07:52:54 -0700 (PDT) MIME-Version: 1.0 References: <20191018052405.3693555-1-bjorn.andersson@linaro.org> <739222E4-F173-42A9-8D67-1BD8FEE227EC@holtmann.org> In-Reply-To: <739222E4-F173-42A9-8D67-1BD8FEE227EC@holtmann.org> From: Jeffrey Hugo Date: Fri, 18 Oct 2019 08:52:43 -0600 Message-ID: Subject: Re: [PATCH 0/4] Bluetooth: hci_qca: Regulator usage cleanup To: Marcel Holtmann Cc: Bjorn Andersson , Johan Hedberg , linux-bluetooth@vger.kernel.org, lkml , MSM Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Fri, Oct 18, 2019 at 1:59 AM Marcel Holtmann wrote: > > Hi Bjorn, > > > Clean up the regulator usage in hci_qca and in particular don't > > regulator_set_voltage() for fixed voltages. It cleans up the driver, but more > > important it makes bluetooth work on my Lenovo Yoga C630, where the regulator > > for vddch0 is defined with a voltage range that doesn't overlap the values in > > the driver. > > > > Bjorn Andersson (4): > > Bluetooth: hci_qca: Update regulator_set_load() usage > > Bluetooth: hci_qca: Don't vote for specific voltage > > Bluetooth: hci_qca: Use regulator bulk enable/disable > > Bluetooth: hci_qca: Split qca_power_setup() > > > > drivers/bluetooth/hci_qca.c | 135 +++++++++++++++--------------------- > > 1 file changed, 55 insertions(+), 80 deletions(-) > > all 4 patches have been applied to bluetooth-next tree. I know this is already applied, but I just wanted to follow up and indicate: Tested-by: Jeffrey Hugo Reviewed-by: Jeffrey Hugo Thanks for the cleanups Bjorn.