Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3684818ybx; Mon, 4 Nov 2019 01:01:09 -0800 (PST) X-Google-Smtp-Source: APXvYqwqJM89Fd3T5uREmuEoqxaKHdBrKiMhAlTwX1wiIGrNt/jQuw8lClax8qv+pKpxOxKAuc+p X-Received: by 2002:a17:906:a986:: with SMTP id jr6mr22696288ejb.158.1572858069255; Mon, 04 Nov 2019 01:01:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572858069; cv=none; d=google.com; s=arc-20160816; b=azHBheGmTdH5uLNhzS6z6muyG686N+L2dAtG7OpKNuiG43SOCcAFGvTcf4YgfpVb9l WNtQpARKfOPjznIVU9/TEk2denIdhovBBS2aUaFb+K2/dUnTdcMj2p9zyaIZ/jCWraAg nToi/jHyOpwZfIQOxe4mJJCACBGNR5obbEFy6zuzOusiz86AoNgmERIjTuwlpWWOY47K DDWgqYttzZq0mx7ypwwK5HEq8z3HTTAPPPYFeP7LfTO9dRs1Bn6+m6X8Qs8FTiwlBt/z 96xm0DxXB29XF5LkrYJYwB+onP2yAa7jBXG6jZ4aiYuuEphOSzzArVRfRyd2Mj+QdKfW KYKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=h9xQea+SV03Ln66aqyU47kkYiIt/H1x4XjCyGKRtAQg=; b=hKCS0aKjJBro8QnFEDZplQKa+bIp+stCFNu5wYaXCJOHM0OHwdh8Ja+xRuFRrar/s1 uCndZsuiuN3m7SwSu0EfTpmmb4QTBDOu1QHa2CfeKzglsy8HBobQ7zcVdcrDs7ABXOvS 5r/8Zkp/mpLw4aeFBZvbXiGK1Eij1Bte5rcQDHR5ZnvKoCuqbp1i0WXeoAnUPs+fNoJW 1SCl667hsIcE/GtNqSenIjNo/CCBU4bE1h0zKvoCr71BU6vTvgqYtzWsHlnXg5COQ8Ae 8ja+QpZTX1kQvBFPMiLmx1is8IfhFkaS9C1RPCAJyBAcFhrYZ+Bz8Y7zAEDC0574GHsT kEFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mWQCKSD6; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v13si8423625edb.164.2019.11.04.01.00.32; Mon, 04 Nov 2019 01:01:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mWQCKSD6; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726633AbfKDJAb (ORCPT + 99 others); Mon, 4 Nov 2019 04:00:31 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:45967 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbfKDJAb (ORCPT ); Mon, 4 Nov 2019 04:00:31 -0500 Received: by mail-pf1-f195.google.com with SMTP id z4so5686360pfn.12 for ; Mon, 04 Nov 2019 01:00:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=h9xQea+SV03Ln66aqyU47kkYiIt/H1x4XjCyGKRtAQg=; b=mWQCKSD6XCLzsZ/4MrvNyveiIs1ALOZKLjnowJFJvYX/Y08gplPnd1S0VUj6uuhuGu hAOVW7pkZgsMuoHcPuKvS1CKrvRlvbSuwu1mjyqN+JvI0x3LMPG2SkeKYbkOZHUF/EL8 VUmUcPn7za8tAMBzuRU/BFW6DCead5B+9eJm7wzgJX+1+cGMqLQpEbzFM+E/hYMu4usH QKUPgjLVQMgbYyb2Ho8WLJ+TdwCK+GcsP/sJJ5MrAj9B4+wrswBi1nfl3Ha1AilKTrUq 3KN7CfwzszyEY+H1XkbWUQ/8VoKvQdgZule81nF7ThFrRI3LABDe0biEFzJae6HL/XaK lrRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=h9xQea+SV03Ln66aqyU47kkYiIt/H1x4XjCyGKRtAQg=; b=iHC9GDRRRnjWUIku6vvM0H3yZ88TMVQI7GidPsAOoTIkrTgnxq11T7hevPtkCNc3Vq /RddISDkG9dTKHRV6biMcFDLlRp8wnshNOaeGSR/u8b4YxAaiu/Fa28TrmrOOffwiUA3 Ox9ClobNTXFqt4pc8HHTU2dXOg95scNTs+9jQO9YshqKUaR7cl80aFp8uof2GIGvCGS5 ZjTuJGUoK65rQ46DKLHzkzn9pU8DFMPsUeFdrLmQ5tRi/NC2A9JdqQZlVjg0fHwi8ivq iFsdwEBm10SlOk7UVTzOgbJVrnbc2b2otrPM9FowmcT4dH2bRVO23fWTai/2dXF6/RRS LWiQ== X-Gm-Message-State: APjAAAUQ6z5vTK/MqiAbqXg5pTfRMjiAZTUPnD2/ABdppX7QylnV6Kuz G5hTsOMNGdZaMx48YnNOkl4= X-Received: by 2002:a63:595:: with SMTP id 143mr28915399pgf.45.1572858030788; Mon, 04 Nov 2019 01:00:30 -0800 (PST) Received: from localhost ([134.134.139.76]) by smtp.gmail.com with ESMTPSA id f30sm9125837pgn.50.2019.11.04.01.00.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 01:00:29 -0800 (PST) Date: Mon, 4 Nov 2019 11:00:26 +0200 From: Johan Hedberg To: Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] Bluetooth: Fix advertising duplicated flags Message-ID: <20191104090026.GA36897@aguefor-mobl1.ger.corp.intel.com> Mail-Followup-To: Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org References: <20191103215815.5310-1-luiz.dentz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191103215815.5310-1-luiz.dentz@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Luiz, On Sun, Nov 03, 2019, Luiz Augusto von Dentz wrote: > Instances may have flags set as part of its data in which case the code > should not attempt to add it again otherwise it can cause duplication: > > < HCI Command: LE Set Extended Advertising Data (0x08|0x0037) plen 35 > Handle: 0x00 > Operation: Complete extended advertising data (0x03) > Fragment preference: Minimize fragmentation (0x01) > Data length: 0x06 > Flags: 0x04 > BR/EDR Not Supported > Flags: 0x06 > LE General Discoverable Mode > BR/EDR Not Supported > > Signed-off-by: Luiz Augusto von Dentz > --- > net/bluetooth/hci_request.c | 9 +++++++++ > 1 file changed, 9 insertions(+) Applied to bluetooth-next. Thanks. Johan