Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1673906ybx; Thu, 7 Nov 2019 15:28:38 -0800 (PST) X-Google-Smtp-Source: APXvYqxmnylSGVe97V7Kct+3PCtLFGHP+ZLl6RuX6OIbnUuhSXPli5v1+Vp4KLYHMnzMmPBlYpdD X-Received: by 2002:a17:906:f191:: with SMTP id gs17mr3572459ejb.207.1573169318116; Thu, 07 Nov 2019 15:28:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573169318; cv=none; d=google.com; s=arc-20160816; b=Ij/Ng+VW8rSd8TCgWRsAuxXF8wfJb1pJoYpwnU0cjSb7rx08Z7J3NRvSj4hiKkVvWZ HBBBJgHU3LxAI8igFyoUfCXmiLeWhCggnBp+l0zrnkH2AsgV88j2SWXajH6lEbgdXXlA cHb0saU3SOS4PfjO/YIO3PRnktg1vAe9YbR4ectT+rnSyXqYD6CXne25RnlBMtX1iiMU ihj28cOfthyfBw7KmaemML5VZs6azsFjaAI+GPZp7NWW0ZPR3lD+Gcxit8EM7bXyRf9s dCFPxLIaukXP+qC/XvKBdLYgznxbNZGvEqR/ONVIzjNJJkOrkD+/A204rY6c9BhD4Jdp OTwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7BmFIfu3M0HZwt+Q5j2ru4f7l0bIsWe0OLM9WwddihI=; b=X+iAeRUAuVjwSWEOmGN+BPQI5Tp5jAfXVCAyMUqz1b5LAb6+KqqeLuK2NTcukc5wcT +Lrf84cbMOn7UPtsFi4HGvvGvvPL7KrRRhI7v5KD69HdnHTikHZ62lJianscRi/BwpYD 9Nneuip1PXubTnG+kPl3D6gVUP56lcm1GSf+Hwvf2jo4XqRMCnfX8lI/ieMzjUelAUk+ gH0jRwN7x1pHFouerqCKcu3qC0nADcxcuBT1Gv1AEym0JMraiFS+cNcjIgDYeX9aXCQM QNaOfiQqM6cH65Rq7Nu8mTWr9nj7gSCpZed/7b+OfcAlu5B1aSERPsDyYsCF5kobry1M 84sQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G9f2QFqb; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3si2508667ejy.286.2019.11.07.15.27.57; Thu, 07 Nov 2019 15:28:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G9f2QFqb; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726834AbfKGX1q (ORCPT + 99 others); Thu, 7 Nov 2019 18:27:46 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:37330 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbfKGX1p (ORCPT ); Thu, 7 Nov 2019 18:27:45 -0500 Received: by mail-pl1-f193.google.com with SMTP id p13so2701543pll.4 for ; Thu, 07 Nov 2019 15:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7BmFIfu3M0HZwt+Q5j2ru4f7l0bIsWe0OLM9WwddihI=; b=G9f2QFqbIpvPzP+ipqv0GmvyF0eGXGh9QMSFOoyB9+jjACRbO5OOZS7NIVxmaNMytG n07iwrwawUQCkkQ+h2iJuX5tvkGdmj+06phZZtSy00G6NxWK5tA+YY4fFcpBzQ/aoZvN vS+ECTdz67UOybb5+svMppyxtzMa3RqNcmQEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7BmFIfu3M0HZwt+Q5j2ru4f7l0bIsWe0OLM9WwddihI=; b=Qvl/cAvAspvZTaeosSv3pgHI8mpsbDIKy5Ta+6ZAxpUR1OxuYxoHBpwwDCcGuPc7AZ c53lfnjQKbTLnsrts1RgRqeBc9avfGFzAWdMGG2QY5mmYlnlqEgsfrGT30EKQ2pc6QwX Ioe7cjrENIwRtTHWWveznoXeVqrIeCTq3D5WYYOONNU5Y4DjRaitzl7lCcsGCPGFXX0M Mj/gNTqc9+1uDVltVTngrmSJ7m6sDZueDMcvJ9VIJo6/51i5Oqq4XmeNXg2a9GPRLlyk 7ki0wYqbZn3KsF9NjRZmcy/70KRkqLLqMWqyNC1ksNDdoLeTjQPfzX4XbxlnspkRUjfR xTGQ== X-Gm-Message-State: APjAAAVME2c/fB9vmHQcgRHqmnrSsIExJyKhCAthL0Ac7/EKezh/o9v6 0dBfZ/IwZ7U8PxWlVF4R+dxYHg== X-Received: by 2002:a17:902:9002:: with SMTP id a2mr6824143plp.133.1573169264975; Thu, 07 Nov 2019 15:27:44 -0800 (PST) Received: from apsdesk.mtv.corp.google.com ([2620:15c:202:1:e09a:8d06:a338:aafb]) by smtp.gmail.com with ESMTPSA id h3sm2857579pji.16.2019.11.07.15.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 15:27:44 -0800 (PST) From: Abhishek Pandit-Subedi To: Marcel Holtmann , Johan Hedberg , Rob Herring Cc: linux-bluetooth@vger.kernel.org, dianders@chromium.org, Abhishek Pandit-Subedi , devicetree@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ondrej Jirman , Mark Rutland , Chen-Yu Tsai Subject: [PATCH v2 0/4] Bluetooth: hci_bcm: Additional changes for BCM4354 support Date: Thu, 7 Nov 2019 15:27:08 -0800 Message-Id: <20191107232713.48577-1-abhishekpandit@chromium.org> X-Mailer: git-send-email 2.24.0.rc1.363.gb1bccd3e3d-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org While adding support for the BCM4354, I discovered a few more things that weren't working as they should have. First, we disallow serdev from setting the baudrate on BCM4354. Serdev sets the oper_speed first before calling hu->setup() in hci_uart_setup(). On the BCM4354, this results in bcm_setup() failing when the hci reset times out. Next, we add support for setting the PCM parameters, which consists of a pair of vendor specific opcodes to set the pcm parameters. The documentation for these params are available in the brcm_patchram_plus package (i.e. https://github.com/balena-os/brcm_patchram_plus). This is necessary for PCM to work properly. All changes were tested with rk3288-veyron-minnie.dts. Changes in v2: - Use match data to disallow baudrate setting - Parse pcm parameters by name instead of as a byte string - Fix prefix for dt-bindings commit Abhishek Pandit-Subedi (4): Bluetooth: hci_bcm: Disallow set_baudrate for BCM4354 Bluetooth: btbcm: Support pcm configuration Bluetooth: hci_bcm: Support pcm params in dts dt-bindings: net: broadcom-bluetooth: Add pcm config .../bindings/net/broadcom-bluetooth.txt | 11 ++++ drivers/bluetooth/btbcm.c | 35 +++++++++++ drivers/bluetooth/btbcm.h | 10 ++++ drivers/bluetooth/hci_bcm.c | 58 ++++++++++++++++++- 4 files changed, 112 insertions(+), 2 deletions(-) -- 2.24.0.rc1.363.gb1bccd3e3d-goog