Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Nov 2019 19:55:58 +0100
From:   Aurelien Jarno <aurelien@aurel32.net>
To:     linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] tools/mesh-cfgclient: add network transmit get/set
 commands
Message-ID: <20191111185558.GA30589@aurel32.net>
References: <20191111130043.5247-1-aurelien@aurel32.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191111130043.5247-1-aurelien@aurel32.net>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On 2019-11-11 14:00, Aurelien Jarno wrote:
> Add network-transmit-get and network-transmit-set commands as per
> Mesh Profile 4.3.2.69, 4.3.2.70 and 4.3.2.71.
> ---
>  tools/mesh/cfgcli.c | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/tools/mesh/cfgcli.c b/tools/mesh/cfgcli.c
> index a4de42943..adc35f5a7 100644
> --- a/tools/mesh/cfgcli.c
> +++ b/tools/mesh/cfgcli.c
> @@ -621,6 +621,15 @@ static bool msg_recvd(uint16_t src, uint16_t idx, uint8_t *data,
>  				src, mesh_status_str(data[0]));
>  
>  		break;
> +
> +	/* Per Mesh Profile 4.3.2.71 */
> +	case OP_CONFIG_NETWORK_TRANSMIT_STATUS:
> +		if (len != 1)
> +			return true;
> +
> +		bt_shell_printf("Node %4.4x: Network transmit cnt %d, steps %d\n",
> +				src, data[0]>>5, data[0] & 0x1f);

Replying to myself, this is wrong as the Foundation Model Layer uses
little endian ordering. I'll send a v2 and fixes for the existing code.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net