Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp6863312ybx; Mon, 11 Nov 2019 16:20:55 -0800 (PST) X-Google-Smtp-Source: APXvYqzt9fmQeuHcUaVlaRh4dMbtAu1y2vpIxpWFvJAQetOTFMI2Kkbe7sIn6593/dv4bRJ1+5od X-Received: by 2002:a17:906:f255:: with SMTP id gy21mr25960732ejb.204.1573518055526; Mon, 11 Nov 2019 16:20:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573518055; cv=none; d=google.com; s=arc-20160816; b=HJybPMtekaCvIiGFvZcnkT1x5s558c3DhddugYIknlcvNOpJfBYxj1T2MMc/SZNoXS Ra11Ih9fD139f/+IQ4lUgpSZicY+wTG61kLmgQTDHTskMcyEmQt/53+9oBUhp/vFP9NR 8mEL4vChak+QzCIQLG2axynygnZhVA6oqAqkopz3P8NGlmKmtaIIRokQOUXl3c9s/uAq SrzbEhyZlRzjFDmGWFF7b+XM/Xog9GOm395gTcqxvHGP169W40OrVHW6A/C1x8LP2eEo uBVRw17tOPt6FzSqybijKmWN3Br7i9FOTN11bON6oD/6DcgVxkcfA1kURpSuPiuF34jM a4AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5m2NG6A+YgxDfMfpQtOFvpd6UPNiApr1ET296m72/Jw=; b=VJPiCCCh1pJGBNqZ0IOFUFLLhQBP11qWm7TCajvk/EhSFM4nFtpQFMtly70R50fhi6 Zikg+ejEse/BNSIyysG/UlNRvxi6L+JeL5KuYbHo8IkWIesDREfVuGrfPjjKFlLSH9Wn e1inS4uuQ0lDZitnNVXKb7T4wA7WTx7sIHTK1kqeni7xMuxbEvM80m5hnekFrfQx7jta Gmzh4MSfwbhkY16vsBed1pzr3R35FIz5nsG/1cUwOUzAMemT+iZH/tIL0gZhrXT08tCn LrSq00AMtk+6DcuWDIIJalSuJdhcBVZKJetFuv+WsxpoW35ws92BduKqelpbTfupRtpP eusg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=LmHtHTSL; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v26si1924664eje.425.2019.11.11.16.20.15; Mon, 11 Nov 2019 16:20:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=LmHtHTSL; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbfKLAUA (ORCPT + 99 others); Mon, 11 Nov 2019 19:20:00 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:44568 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726928AbfKLAUA (ORCPT ); Mon, 11 Nov 2019 19:20:00 -0500 Received: by mail-pf1-f193.google.com with SMTP id q26so11942379pfn.11 for ; Mon, 11 Nov 2019 16:19:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5m2NG6A+YgxDfMfpQtOFvpd6UPNiApr1ET296m72/Jw=; b=LmHtHTSLUL2+tujgPcdLdh4oJucSyAFboxlu4pQO4dgCTYOivpUDb3eZljCFo9YCiz iTRgV4e8h/ACWzZ/aDa3yjZj7HO2PXQlYaUzp4oKePffml2I6UilI1IysWAwh8LQVBK+ 31as/o7Db8bOeXEV7OuMzb3FcZwiaH3AX5Fic= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5m2NG6A+YgxDfMfpQtOFvpd6UPNiApr1ET296m72/Jw=; b=fU/FFPuEupgmNIf4JZfkYiVKdidLuOKyclfb/ZuhcXQB8CLEyJ4dY6JoP6+t33OyjB IQPRXFvuqta9/g/g8GAhQwCM2Le/F2+yH3fBhO01veUqXSjuDEG9npbnti4SUMeUTI7/ oamJD9X7aWmeLA/OGyC49nb5heCOHZxPx+gtZTG4DfKvz4kREJtcTBCtH/ECGwYS/s4e pyvkOvtguYyfkAg3xyZ2To23OBnpKXFQfrf4lkUjZWfc3hrq4OPMaRnachFGSEkrTT5X GSNCLjCpoBsFvyDP/8Vq64jAdNpFyVzP6TE8NkT4oa/EUDjvQGYZIUSsN66MGeunG208 zRgw== X-Gm-Message-State: APjAAAXbjEBRiTBo4vbbHe8cePfw+AGPlqximYU5uNU9aMLRRWGA4MkH Mk0p2EX8RU7wCONkM1UgDSWrVw== X-Received: by 2002:a63:77c3:: with SMTP id s186mr9434885pgc.370.1573517999167; Mon, 11 Nov 2019 16:19:59 -0800 (PST) Received: from apsdesk.mtv.corp.google.com ([2620:15c:202:1:e09a:8d06:a338:aafb]) by smtp.gmail.com with ESMTPSA id h23sm8430898pgg.58.2019.11.11.16.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 16:19:58 -0800 (PST) From: Abhishek Pandit-Subedi To: Marcel Holtmann , Johan Hedberg , Rob Herring Cc: linux-bluetooth@vger.kernel.org, dianders@chromium.org, Abhishek Pandit-Subedi , devicetree@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ondrej Jirman , Mark Rutland , Chen-Yu Tsai Subject: [PATCH v3 0/4] Bluetooth: hci_bcm: Additional changes for BCM4354 support Date: Mon, 11 Nov 2019 16:19:45 -0800 Message-Id: <20191112001949.136377-1-abhishekpandit@chromium.org> X-Mailer: git-send-email 2.24.0.rc1.363.gb1bccd3e3d-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org While adding support for the BCM4354, I discovered a few more things that weren't working as they should have. First, we disallow serdev from setting the baudrate on BCM4354. Serdev sets the oper_speed first before calling hu->setup() in hci_uart_setup(). On the BCM4354, this results in bcm_setup() failing when the hci reset times out. Next, we add support for setting the PCM parameters, which consists of a pair of vendor specific opcodes to set the pcm parameters. The documentation for these params are available in the brcm_patchram_plus package (i.e. https://github.com/balena-os/brcm_patchram_plus). This is necessary for PCM to work properly. All changes were tested with rk3288-veyron-minnie.dts. Changes in v3: - Change disallow baudrate setting to return -EBUSY if called before ready. bcm_proto is no longer modified and is back to being const. - Changed btbcm_set_pcm_params to btbcm_set_pcm_int_params - Changed brcm,sco-routing to brcm,bt-sco-routing Changes in v2: - Use match data to disallow baudrate setting - Parse pcm parameters by name instead of as a byte string - Fix prefix for dt-bindings commit Abhishek Pandit-Subedi (4): Bluetooth: hci_bcm: Disallow set_baudrate for BCM4354 Bluetooth: btbcm: Support pcm configuration Bluetooth: hci_bcm: Support pcm params in dts dt-bindings: net: broadcom-bluetooth: Add pcm config .../bindings/net/broadcom-bluetooth.txt | 11 +++ drivers/bluetooth/btbcm.c | 18 +++++ drivers/bluetooth/btbcm.h | 8 +++ drivers/bluetooth/hci_bcm.c | 70 ++++++++++++++++++- 4 files changed, 106 insertions(+), 1 deletion(-) -- 2.24.0.rc1.363.gb1bccd3e3d-goog