Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp628017ybc; Tue, 12 Nov 2019 06:55:13 -0800 (PST) X-Google-Smtp-Source: APXvYqx10jRPxCvT7/6Wv1sf3jw0t4m19Ej17VxNIyYPr9fWZpDGEOZTpr1LyfRUaImVOp/SRVgF X-Received: by 2002:a17:906:1249:: with SMTP id u9mr29376221eja.253.1573570513685; Tue, 12 Nov 2019 06:55:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573570513; cv=none; d=google.com; s=arc-20160816; b=INhVfDyzBJzzwbNKx3WpQe9iQpO9+gkKu/GnR/DQFQlnVNT/MFm7i+eY84haVeaO1f BlSZ+R8aSJByaVA8I8zD8lU+WDKIFVHZJsZHGfFwhTYaDYNUBhwtbdDBUkkNgOdJLsRY 4M3pFnHbVpAJ+OI+P01edCsY01ZuvphQYtp4Tc2tgKVPQG+ccPa/uQ+zg6YgOM6GvbKQ NAjsrYdoT+gsx3vIKlUzrtgpSmtjB4r4/WlGCPiswwraUhmsSInlnif7ShC6a4NGm9SU tJNSwKXtoPUuIdoNmMoomLjvbz1e1+fhmt0XRJSrHSqTJR3VPqtizH72NJNktVWczhZp epeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=s8Qq1ijr+e9R5gPAvVvz71fzXphQW8SpvCMlfr0BT9k=; b=qX7Fb2RxTqnCxem7HjfV0I7s3KhP2Wx0NvjD/JS8uO4mbp5SFRI1PHD4uAODN6NBji AXSPkCA9YKG+8UUrCbItuk+fl2cr6E4k470BSn+BgkcdRC3kRodK24+QXkgWebBf2QjR KlXVMEZKfiCYA07Z3Mvw3MlHJoscIDusbQP6NRsrNn9w7CusORvp1U6sog2JybgayKtT dSGa9UHNqE9uRZ43eb37uNsQR2l5CizPWFPOi72a15VDmL9LvT2YLPBvC2kSYPGzJWjl h7Td+fNtv4+fALuyJtKtmK5161BmTtTu8TiaIeDHjIxLP72XAB7OKT9Q6PiG5NX+6Gt9 wzgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=kMttzkOL; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r25si94753eji.283.2019.11.12.06.54.35; Tue, 12 Nov 2019 06:55:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=kMttzkOL; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726697AbfKLOye (ORCPT + 99 others); Tue, 12 Nov 2019 09:54:34 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:33465 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726484AbfKLOye (ORCPT ); Tue, 12 Nov 2019 09:54:34 -0500 Received: by mail-lf1-f67.google.com with SMTP id d6so12681601lfc.0 for ; Tue, 12 Nov 2019 06:54:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silvair-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=s8Qq1ijr+e9R5gPAvVvz71fzXphQW8SpvCMlfr0BT9k=; b=kMttzkOLFOCXo0k+TFdHBpL0FJl4llSIt9Mw0+OrOeEv4FReXcT5jjHvU5pEu1/XzQ FT8BrcMi5MdyY7aWCKE6QoHFjvYx3Z8YtOXGevZVZAn8YzRUpKzd0n5szGX5F+FfPgHu lFuIpAD/nbhdJemLM0VkjXdqSuf4A86Bn01aT6HPlYhwk4y3DISn1d0GG3XuiWulorbU 1AtVDgUV+M4u3v1yuDABCeu+cIwLrfzO71r0mf+0u7TUqjFTUDXPNPU+PbZWMPpVyyT1 IeTfQOQOQHo40lRlcCRpot7NuigFpnW5cJdfMd91/+toSEA0GyOv8ltJ+hun9C1PxOyg 3WCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=s8Qq1ijr+e9R5gPAvVvz71fzXphQW8SpvCMlfr0BT9k=; b=tbclHd5FbkC3Ky+Ht2JYSM52tP9hHH096moJbDgLM+UwCEzxsXCyx4879nKUpYUZkA Wh8LZI536y92biJDSX0olPhizILRYryVDSc4VNKCqyFuCI6uBue17sJvMdMB88B3d/qy gWxQGcmzMS4YTKRh0j+8mdcc+Hj/upIJrraHlUCSU1Dk3UsIZjwZ8UpmDraCcF9fv8mk WJNou1DmbUGp1assPM2PvvLDaLatWB7u5JD2gtlAubLCoA9ybLXCZODEJJFwU5+J0e4+ wvNl3sI5C1OGck8jhoSlY8sI3GL59/3AgIqae2Q3GIjUeJ8PT2uPhQNpc1Y5MAs9HmSA sWdA== X-Gm-Message-State: APjAAAUmXcAERZiesLENWKhqOB5s2bXQKcCd6g48zKoUFEz1Kt2Vqm7i Fw+Nq4XDkdFKYsZcIj6sgWBw2nnqybXFKA== X-Received: by 2002:a19:da1a:: with SMTP id r26mr20322883lfg.60.1573570472008; Tue, 12 Nov 2019 06:54:32 -0800 (PST) Received: from mlowasrzechonek2133.silvair.lan ([217.153.94.18]) by smtp.gmail.com with ESMTPSA id x12sm8398361lfq.52.2019.11.12.06.54.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 06:54:31 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20Lowas-Rzechonek?= To: linux-bluetooth@vger.kernel.org Subject: [PATCH BlueZ] mesh: Fix ignored return value Date: Tue, 12 Nov 2019 15:54:25 +0100 Message-Id: <20191112145425.6318-1-michal.lowas-rzechonek@silvair.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org This fixes the following build error when compiling in maintainer mode: mesh/keyring.c: In function ‘finalize’: mesh/keyring.c:142:8: error: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Werror=unused-result] (void)write(fd, &key, sizeof(key)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- mesh/keyring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mesh/keyring.c b/mesh/keyring.c index 9fa7d6bd0..fe292b4a7 100644 --- a/mesh/keyring.c +++ b/mesh/keyring.c @@ -140,7 +140,8 @@ static void finalize(const char *fpath, uint16_t net_idx) l_debug("Finalize %s", fpath); memcpy(key.old_key, key.new_key, 16); lseek(fd, 0, SEEK_SET); - write(fd, &key, sizeof(key)); + if (write(fd, &key, sizeof(key)) != sizeof(key)) + goto done; done: close(fd); -- 2.19.1