Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1141703ybc; Tue, 12 Nov 2019 15:10:58 -0800 (PST) X-Google-Smtp-Source: APXvYqy8u22AGdVT3gHZWuOXPu0I3Z/mTQ8NbsSTy2qSgH1ZgyQISZQmRL7o+a3QTOMTdrzRlXyx X-Received: by 2002:a50:f284:: with SMTP id f4mr291329edm.126.1573600258582; Tue, 12 Nov 2019 15:10:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573600258; cv=none; d=google.com; s=arc-20160816; b=drQBhw//9FkDUP5D8IUtiq0Byml69n0wiUTZxj4ht1GmAA6j5SDPS7+4DSzTtSDutC 5CBC72RLsk+ZkFyJWptjHwAERhJFcR/hUW83RWGKExehby8yM5hTmoCK1+WPl69H14y5 QwwA34Huricf43YQlklbKuduNEI05RTYokW+ubVIv9skdr5yjtZ4XbyYXBdArKQuQ/OA gA/kXV5yd4FRfTeDs4djnUkBsawlP9x0KnwrHlE0k6i7AUx5OGzjmF8AC9Ho5LWwIIj0 w/ceRXXDjgqjaa5trtKOvCHEIOAA8iTsRAGChr9KatoorjL5j1ZZ0AlJyXr+xHKibQWO mFTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LydOC1DwmxI2sNIO6iFBTA3xFx+jTLk/yQNmWdXlHJk=; b=P8NXOIs/k+kT1mb+Pn/SWiuqOVmM0IlzA5IiDKitGlVySrMnE79WriM45mt79AXtg9 4TFjnz8DWvKNNPmO9zY5UJAtE2yPltsF4W92cFdijJaoaZkuO1K1eZtOmWDsYkbr2c8/ d9pUTEZqLZZ3HymtVcKzxJ+aOWzgT25c2yVdQe7XrGKQS0vsIs9el32INzA58CkU3hbK zcg+Gq0ZFxe4PzI94Sxo9IZW6r3ikVNxW6o2NEjGWM5ysZKSoiSVvByeERxQ7IhCJrzx xMDONhHsG7XH4EDdaOOXFrkxTisaU7iNnVIdUpzxfUxa57FpM3yplAyrKia0jSVuyBDF Lw+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CSfbykNR; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g4si28101edj.263.2019.11.12.15.10.28; Tue, 12 Nov 2019 15:10:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CSfbykNR; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726958AbfKLXKJ (ORCPT + 99 others); Tue, 12 Nov 2019 18:10:09 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:41899 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726959AbfKLXKJ (ORCPT ); Tue, 12 Nov 2019 18:10:09 -0500 Received: by mail-pg1-f196.google.com with SMTP id h4so12851537pgv.8 for ; Tue, 12 Nov 2019 15:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LydOC1DwmxI2sNIO6iFBTA3xFx+jTLk/yQNmWdXlHJk=; b=CSfbykNRr/kZprvyug9yN7jxfsahG3sKtvlj0FTZEfLMtXVmQFja13sfE86jS/Kjcq yy6uGqNTSIt1d9ic01WJzZ1EKf1DR69aNFAqf+UcTJagDpBsq7aXpHgRm4LvdMZNhZI7 R0YdwWFImnPlGvyw+BDXNZQy/I2yHb8JrW308= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LydOC1DwmxI2sNIO6iFBTA3xFx+jTLk/yQNmWdXlHJk=; b=SRzZK7N/KZIpTXPD2tf6TQjFp8vEwZr33sWVCeqrqIS0feAhC+kZ/GIzcpRiF2ogn3 d/38R5/k9rdSdQ5ncRTQDdxmy7o5QCx/UO17s71wnjn7WqPFOWvXMltPDRaIyx0HQoPf GrMl7tyQzxdZdUC9wgoPklRiIv9PxIWXD8OIzR6TS06UOQtrcYDjLqcqcQLosX35NQYF 93iDP6nPfaiQgK/O5vNBOFoKni0PWSkE6qI/TCJBpqf+qsfrmqdcLhRZoWiC6zznY3NY 8dTztFQsczAgKhBmYvNoCKD1xlA74uf1lMFyU61lOK3NHh5Ujoyr+nwIfMckf6EUi20y O1wQ== X-Gm-Message-State: APjAAAXLodmvrCZq+/tJGRPhhRnJn2i2nvH9T1MN1qFNd5XL+VWNJY3e v1/G8EMiNQ22bFvuwolJmXECHA== X-Received: by 2002:a63:d308:: with SMTP id b8mr52368pgg.246.1573600207944; Tue, 12 Nov 2019 15:10:07 -0800 (PST) Received: from apsdesk.mtv.corp.google.com ([2620:15c:202:1:e09a:8d06:a338:aafb]) by smtp.gmail.com with ESMTPSA id w27sm67694pgc.20.2019.11.12.15.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 15:10:06 -0800 (PST) From: Abhishek Pandit-Subedi To: Marcel Holtmann , Johan Hedberg , Rob Herring Cc: linux-bluetooth@vger.kernel.org, dianders@chromium.org, Abhishek Pandit-Subedi , devicetree@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ondrej Jirman , Mark Rutland , Chen-Yu Tsai Subject: [PATCH v4 0/4] Bluetooth: hci_bcm: Additional changes for BCM4354 support Date: Tue, 12 Nov 2019 15:09:40 -0800 Message-Id: <20191112230944.48716-1-abhishekpandit@chromium.org> X-Mailer: git-send-email 2.24.0.rc1.363.gb1bccd3e3d-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org While adding support for the BCM4354, I discovered a few more things that weren't working as they should have. First, we disallow serdev from setting the baudrate on BCM4354. Serdev sets the oper_speed first before calling hu->setup() in hci_uart_setup(). On the BCM4354, this results in bcm_setup() failing when the hci reset times out. Next, we add support for setting the PCM parameters, which consists of a pair of vendor specific opcodes to set the pcm parameters. The documentation for these params are available in the brcm_patchram_plus package (i.e. https://github.com/balena-os/brcm_patchram_plus). This is necessary for PCM to work properly. All changes were tested with rk3288-veyron-minnie.dts. Changes in v4: - Fix incorrect function name in hci_bcm Changes in v3: - Change disallow baudrate setting to return -EBUSY if called before ready. bcm_proto is no longer modified and is back to being const. - Changed btbcm_set_pcm_params to btbcm_set_pcm_int_params - Changed brcm,sco-routing to brcm,bt-sco-routing Changes in v2: - Use match data to disallow baudrate setting - Parse pcm parameters by name instead of as a byte string - Fix prefix for dt-bindings commit Abhishek Pandit-Subedi (4): Bluetooth: hci_bcm: Disallow set_baudrate for BCM4354 Bluetooth: btbcm: Support pcm configuration Bluetooth: hci_bcm: Support pcm params in dts dt-bindings: net: broadcom-bluetooth: Add pcm config .../bindings/net/broadcom-bluetooth.txt | 11 +++ drivers/bluetooth/btbcm.c | 18 +++++ drivers/bluetooth/btbcm.h | 8 +++ drivers/bluetooth/hci_bcm.c | 69 ++++++++++++++++++- 4 files changed, 105 insertions(+), 1 deletion(-) -- 2.24.0.rc1.363.gb1bccd3e3d-goog