Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5dcd8c98.1c69fb81.4690b.49fe@mx.google.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20191114081430.25427-1-bgodavar@codeaurora.org>
References: <20191114081430.25427-1-bgodavar@codeaurora.org>
Cc:     mka@chromium.org, linux-kernel@vger.kernel.org,
        linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org,
        linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org,
        tientzu@chromium.org, seanpaul@chromium.org
To:     Balakrishna Godavarthi <bgodavar@codeaurora.org>,
        johan.hedberg@gmail.com, marcel@holtmann.org
From:   Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH v1] Bluetooth: hci_qca: Enable clocks required for BT SOC
User-Agent: alot/0.8.1
Date:   Thu, 14 Nov 2019 09:19:19 -0800
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Quoting Balakrishna Godavarthi (2019-11-14 00:14:30)
> @@ -1423,6 +1427,20 @@ static int qca_power_off(struct hci_dev *hdev)
>         return 0;
>  }
> =20
> +static int qca_power_on(struct qca_serdev *qcadev)
> +{
> +       int err;
> +
> +       if (qcadev->susclk) {

clk_prepare_enable() shouldn't return anything besides 0 when passed a
NULL pointer. Please drop this if condition in addition to the one on
the clk_disable_unprepare().

> +               err =3D clk_prepare_enable(qcadev->susclk);
> +               if (err)
> +                       return err;
> +       }