Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\))
Subject: Re: [PATCH] btusb: fix PM leak in error case of setup
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20191114150118.5237-1-oneukum@suse.com>
Date:   Fri, 15 Nov 2019 09:07:33 +0100
Cc:     ytkim@qca.qualcomm.com, Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 7bit
Message-Id: <F5BB5814-4B00-4DD8-BF33-7996CA7E1518@holtmann.org>
References: <20191114150118.5237-1-oneukum@suse.com>
To:     Oliver Neukum <oneukum@suse.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Oliver,

> If setup() fails a reference for runtime PM has already
> been taken. Proper use of the error handling in btusb_open()is needed.
> You cannot just return.
> 
> Fixes: ace31982585a3 ("Bluetooth: btusb: Add setup callback for chip
> init on USB")
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
> drivers/bluetooth/btusb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel