Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 16 Nov 2019 13:07:49 +0100
From:   Aurelien Jarno <aurelien@aurel32.net>
To:     Brian Gix <brian.gix@intel.com>
Cc:     linux-bluetooth@vger.kernel.org, inga.stotland@intel.com
Subject: Re: [PATCH BlueZ v2 0/2] mesh: Fix inOOB and outOOB issues
Message-ID: <20191116120749.GC30589@aurel32.net>
References: <20191115231705.5596-1-brian.gix@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191115231705.5596-1-brian.gix@intel.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On 2019-11-15 15:17, Brian Gix wrote:
> This patchset includes modification to both the Daemon and the
> mesh-cfgclient.  All of the inOOB and outOOB scenarios have been tested,
> and are working according to the Bluetooth Profile specification, for
> the Provisioner "Initiator" role.
> 
> Brian Gix (1):
>   mesh: Fix inOOB and outOOB agent handling on prov initiate
> 
> Inga Stotland (1):
>   tools/mesh-cfgclient: Add full support inOOB and outOOB
> 
>  mesh/agent.c           |  12 +--
>  mesh/prov-initiator.c  |  69 +++++++++++++---
>  tools/mesh-cfgclient.c | 178 ++++++++++++++++++++++++++++++++++-------
>  tools/mesh-gatt/prov.c |   9 ++-
>  tools/mesh/agent.c     |  21 +++--
>  tools/mesh/agent.h     |   4 +-
>  6 files changed, 233 insertions(+), 60 deletions(-)

Thanks for the patches. I have just tried them and I confirm it fixes
output OOB with number. Output OOB with string still doesn't work. I
came up with this patch to fix it:

diff --git a/mesh/agent.c b/mesh/agent.c
index 623f2faf0..e5545d7f3 100644
--- a/mesh/agent.c
+++ b/mesh/agent.c
@@ -604,7 +604,7 @@ int mesh_agent_prompt_number(struct mesh_agent *agent, bool initiator,
 int mesh_agent_prompt_alpha(struct mesh_agent *agent, mesh_agent_key_cb_t cb,
 								void *user_data)
 {
-	return prompt_input(agent, "in-alpha", MESH_AGENT_REQUEST_IN_ALPHA,
+	return prompt_input(agent, "out-alpha", MESH_AGENT_REQUEST_OUT_ALPHA,
 							false, cb, user_data);
 }

Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net