Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 18 Nov 2019 06:21:49 +0000
From:   bgodavar@codeaurora.org
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     johan.hedberg@gmail.com, marcel@holtmann.org, mka@chromium.org,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org,
        tientzu@chromium.org, seanpaul@chromium.org
Subject: Re: [PATCH v1] Bluetooth: hci_qca: Enable clocks required for BT SOC
In-Reply-To: <5dcd8c98.1c69fb81.4690b.49fe@mx.google.com>
References: <20191114081430.25427-1-bgodavar@codeaurora.org>
 <5dcd8c98.1c69fb81.4690b.49fe@mx.google.com>
Message-ID: <0101016e7d2ca862-0ec3d2c5-c309-4d97-9221-f09480b17c02-000000@us-west-2.amazonses.com>
User-Agent: Roundcube Webmail/1.3.9
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Stephen,

On 2019-11-14 22:49, Stephen Boyd wrote:
> Quoting Balakrishna Godavarthi (2019-11-14 00:14:30)
>> @@ -1423,6 +1427,20 @@ static int qca_power_off(struct hci_dev *hdev)
>>         return 0;
>>  }
>> 
>> +static int qca_power_on(struct qca_serdev *qcadev)
>> +{
>> +       int err;
>> +
>> +       if (qcadev->susclk) {
> 
> clk_prepare_enable() shouldn't return anything besides 0 when passed a
> NULL pointer. Please drop this if condition in addition to the one on
> the clk_disable_unprepare().
> 
>> +               err = clk_prepare_enable(qcadev->susclk);
>> +               if (err)
>> +                       return err;
>> +       }

[Bala]: will update.

Regards
Balakrishna