Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Daniele Biagetti <daniele.biagetti@cblelectronics.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     Daniele <dbiagio@tiscali.it>
Subject: [PATCH 2/6] tools/mesh: Fix status messages processing
Date:   Mon, 18 Nov 2019 14:44:01 +0100
Message-Id: <20191118134405.20212-3-daniele.biagetti@cblelectronics.com>
In-Reply-To: <20191118134405.20212-1-daniele.biagetti@cblelectronics.com>
References: <20191118134405.20212-1-daniele.biagetti@cblelectronics.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

From: Daniele <dbiagio@tiscali.it>

The status messages was processed and displayed even if they do
not belong to the present model. This fix ensure that the status
messages are processed only if they have the correct opcode.
---
 tools/mesh/node.c        | 11 +++++++++++
 tools/mesh/onoff-model.c | 19 ++++++++++++-------
 2 files changed, 23 insertions(+), 7 deletions(-)

diff --git a/tools/mesh/node.c b/tools/mesh/node.c
index d23315ce4..3171ef01a 100644
--- a/tools/mesh/node.c
+++ b/tools/mesh/node.c
@@ -475,6 +475,8 @@ static bool deliver_model_data(struct mesh_element* e=
lement, uint16_t src,
 				uint16_t app_idx, uint8_t *data, uint16_t len)
 {
 	GList *l;
+	uint32_t opcode;
+	int n;
=20
 	for(l =3D element->models; l; l =3D l->next) {
 		struct mesh_model *model =3D l->data;
@@ -487,6 +489,15 @@ static bool deliver_model_data(struct mesh_element* =
element, uint16_t src,
 			return true;
 	}
=20
+	if (mesh_opcode_get(data, len, &opcode, &n)) {
+		len -=3D n;
+		data +=3D n;
+	} else
+		return false;
+	bt_shell_printf("Unknown Model Message received (%d) opcode %x\n",
+						len, opcode);
+	print_byte_array("\t",data, len);
+
 	return false;
 }
=20
diff --git a/tools/mesh/onoff-model.c b/tools/mesh/onoff-model.c
index 6236e1fea..a6baeb0c5 100644
--- a/tools/mesh/onoff-model.c
+++ b/tools/mesh/onoff-model.c
@@ -111,6 +111,7 @@ static bool client_msg_recvd(uint16_t src, uint8_t *d=
ata,
 {
 	uint32_t opcode;
 	int n;
+	char s[128];
=20
 	if (mesh_opcode_get(data, len, &opcode, &n)) {
 		len -=3D n;
@@ -127,18 +128,22 @@ static bool client_msg_recvd(uint16_t src, uint8_t =
*data,
 		return false;
=20
 	case OP_GENERIC_ONOFF_STATUS:
+		bt_shell_printf("On Off Model Message received (%d) opcode %x\n",
+			len, opcode);
+		print_byte_array("\t",data, len);
 		if (len !=3D 1 && len !=3D 3)
 			break;
=20
-		bt_shell_printf("Node %4.4x: Off Status present =3D %s",
-						src, data[0] ? "ON" : "OFF");
-
+		sprintf(s, "Node %4.4x: On Off Status present =3D %s",
+			src, data[0] ? "ON" : "OFF");
 		if (len =3D=3D 3) {
-			bt_shell_printf(", target =3D %s",
-					data[1] ? "ON" : "OFF");
+			sprintf(s, ", target =3D %s",
+				data[1] ? "ON" : "OFF");
+			bt_shell_printf("%s\n", s);
 			print_remaining_time(data[2]);
-		} else
-			bt_shell_printf("\n");
+		}else
+			bt_shell_printf("%s\n", s);
+
 		break;
 	}
=20
--=20
2.20.1