Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 21 Nov 2019 16:41:38 +0200
From:   Johan Hedberg <johan.hedberg@gmail.com>
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Move error check into the right if-clause
Message-ID: <20191121144138.GA70662@vaespino-mobl1.amr.corp.intel.com>
Mail-Followup-To: Marcel Holtmann <marcel@holtmann.org>,
        linux-bluetooth@vger.kernel.org
References: <20191121075130.92705-1-marcel@holtmann.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191121075130.92705-1-marcel@holtmann.org>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel,

On Thu, Nov 21, 2019, Marcel Holtmann wrote:
> The if-clause for hdev->setup should also include the error handling
> since that is where the error really comes from. The code currently
> works correctly since ret=0 is assigned early on, but it is a lot
> harder to read and understand.
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  net/bluetooth/hci_core.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Both patches in this set have been applied to bluetooth-next. Thanks.

Johan