Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\))
Subject: Re: [PATCH 1/2] Bluetooth: Move error check into the right if-clause
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20191121144138.GA70662@vaespino-mobl1.amr.corp.intel.com>
Date:   Fri, 22 Nov 2019 00:36:50 +0100
Cc:     linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <1ACA0CFD-B0A2-41D9-9AB3-295DE534511B@holtmann.org>
References: <20191121075130.92705-1-marcel@holtmann.org>
 <20191121144138.GA70662@vaespino-mobl1.amr.corp.intel.com>
To:     Johan Hedberg <johan.hedberg@gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Johan,

>> The if-clause for hdev->setup should also include the error handling
>> since that is where the error really comes from. The code currently
>> works correctly since ret=0 is assigned early on, but it is a lot
>> harder to read and understand.
>> 
>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
>> ---
>> net/bluetooth/hci_core.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Both patches in this set have been applied to bluetooth-next. Thanks.

so my cleanup patch was actually a mistake. In itself it was the right fix, but with the follow up patch, we actually want it that way to allow the invalid_bdaddr variable assignment to be done after hdev->setup.

I posted a v2 now that fixes that. We need to do a push --force to fix this up. A follow up patch would cause a hard to track history.

Regards

Marcel