Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp631873ybc; Fri, 22 Nov 2019 10:31:01 -0800 (PST) X-Google-Smtp-Source: APXvYqwvbEMPW0Y33u7dljdHSaqbu4kn8i9VxFRsjEWXCSAdgrwgIDVZVbihMPMgBGAehAjVMnv1 X-Received: by 2002:a17:906:cc93:: with SMTP id oq19mr23781209ejb.316.1574447461518; Fri, 22 Nov 2019 10:31:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574447461; cv=none; d=google.com; s=arc-20160816; b=DerKuhJ6nj0oukWyg+Fw8jCHpfopkUPu7AkBvyrr+4tDfwrvCKheldFrOROI16KLd0 1l1PBqsiUjr4WEc0BAi61t9UXHCjr0e+AFXG+bed7jOWQP6qFM/JFWz9JD15ZEiAA1j7 v1eYYLSRtvGAv293Y27xpQrxtTnDwYxivjYJS1JHjMULYygwOXncB+vCGD7cFf+lq/HF chYJ2fp/mLSTTINE5x9HuKfo1osulQjyqbvdx1B5Jmf9/thsNepeQ15TH2eFFPc+noGS daaC/vSYK0w7ewB8zIXoEZYPTo/p8ufExv+779gcDBSi+NInHkFXI/sLwlwcRkutgMkw Bk/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=37CSBQS92W7LbBijpS67O7aUHqGUVLuDb3CYBO6an1k=; b=c2EdjeTSoDfZmbcw6/gTsDEn+yhATaBPG18QrwZOqIAn2IZS2MFh+oel5XyZd14uOP 5Aj+c27dCJp9z/Jtv5iw667LbXZOLEHSWmGbTboY98Fs9ldyGSeoPI6qTmN8Y3yQHTcL pAAErVqGHkBCIZguyaUS1BJfKSwWY/A++dTHgl2L+ekYUIbSdugoEqsNA+nAnmcOwtj6 958CpEPCOzb039TPpHCyFVnNKkr5M0ScCeYEKEzdA2X9R01uoLypj1HLViIED9f62x1k cuUM3tyFoJSmyueCy/j/EviRQG6CZuMI7VlG1Uqk9LryOEWWC6CtLfgQ6w8Vqiug3/UT verQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c8si5608192ede.323.2019.11.22.10.30.16; Fri, 22 Nov 2019 10:31:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726698AbfKVSaG (ORCPT + 99 others); Fri, 22 Nov 2019 13:30:06 -0500 Received: from jax4mhob19.registeredsite.com ([64.69.218.107]:44686 "EHLO jax4mhob19.registeredsite.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbfKVSaG (ORCPT ); Fri, 22 Nov 2019 13:30:06 -0500 Received: from mailpod.hostingplatform.com ([10.30.71.94]) by jax4mhob19.registeredsite.com (8.14.4/8.14.4) with ESMTP id xAMIU3GU098031 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 22 Nov 2019 13:30:04 -0500 Received: (qmail 83830 invoked by uid 0); 22 Nov 2019 18:30:03 -0000 X-TCPREMOTEIP: 65.41.18.216 X-Authenticated-UID: sbrown@opensat.com Received: from unknown (HELO 155-15-85-208.altiusbb.net) (sbrown@opensat.com@65.41.18.216) by 0 with ESMTPA; 22 Nov 2019 18:30:03 -0000 Received: from localhost (localhost [127.0.0.1]) by 155-15-85-208.altiusbb.net (Postfix) with ESMTP id D892F154053D; Fri, 22 Nov 2019 13:30:02 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at ewol.com X-Spam-Flag: NO X-Spam-Score: -2.9 X-Spam-Level: X-Spam-Status: No, score=-2.9 tagged_above=-999 required=6.31 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9] autolearn=ham autolearn_force=no Received: from 155-15-85-208.altiusbb.net ([127.0.0.1]) by localhost (fl-server.ewol.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kg9bJKFiO9wm; Fri, 22 Nov 2019 13:29:56 -0500 (EST) Received: from nm-ws (unknown [192.168.2.3]) by 155-15-85-208.altiusbb.net (Postfix) with ESMTPS id 3E08815402C2; Fri, 22 Nov 2019 13:29:56 -0500 (EST) Message-ID: <66904b9fe3f94ab7bf7fbe173b6d46486a2da6af.camel@ewol.com> Subject: Re: [PATCH BlueZ] tools/mesh-cfgclient: Fix signatures in agent methods From: Steve Brown To: Inga Stotland , linux-bluetooth@vger.kernel.org Cc: brian.gix@intel.com Date: Fri, 22 Nov 2019 11:29:54 -0700 In-Reply-To: <20191122162331.10096-1-inga.stotland@intel.com> References: <20191122162331.10096-1-inga.stotland@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Inga, On Fri, 2019-11-22 at 08:23 -0800, Inga Stotland wrote: > This removes an extra return parameter from PromptNumeric and > PromptStatic > method signatures. Also, style fixes. > --- > tools/mesh-cfgclient.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/tools/mesh-cfgclient.c b/tools/mesh-cfgclient.c > index 1c617a37b..200eb5b84 100644 > --- a/tools/mesh-cfgclient.c > +++ b/tools/mesh-cfgclient.c > SIGSEGV still gone. I tested both the prompt_numeric_call and prompt_static_call paths and they work as expected. I used the Zephyr onoff-app for testing. I think the commit message refers to the V1 patch. Steve