Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191123100111.219190-3-marcel@holtmann.org>
In-Reply-To: <20191123100111.219190-3-marcel@holtmann.org>
From:   Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Date:   Mon, 25 Nov 2019 10:15:49 -0800
Message-ID: <CANFp7mV89ZY=dNeY=QqB3FG1NLrWMdQ-CWxG0rtWBQMVxcXMvw@mail.gmail.com>
Subject: Re: [PATCH 3/4] dt-bindings: net: bluetooth: update broadcom-bluetooth
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On Sat, Nov 23, 2019 at 2:01 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> From: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
>
> Add documentation for brcm,bt-pcm-int-params vendor specific
> configuration of the SCO PCM settings.
>
> Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  .../devicetree/bindings/net/broadcom-bluetooth.txt         | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> index f16b99571af1..065f2e117eca 100644
> --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> @@ -30,6 +30,12 @@ Optional properties:
>     - "lpo": external low power 32.768 kHz clock
>   - vbat-supply: phandle to regulator supply for VBAT
>   - vddio-supply: phandle to regulator supply for VDDIO
> + - brcm,bt-pcm-int-params: configure PCM parameters via a 5-byte array
> +    - sco-routing: PCM, Transport, Codec, I2S
Consider, 0 = PCM to show 0-indexing.
> +    - pcm-interface-rate: 128KBps, 256KBps, 512KBps, 1024KBps, 2048KBps
> +    - pcm-frame-type: short, long
> +    - pcm-sync-mode: slave, master
> +    - pcm-clock-mode: slave, master
>
>
>  Example:
> @@ -41,5 +47,6 @@ Example:
>         bluetooth {
>                 compatible = "brcm,bcm43438-bt";
>                 max-speed = <921600>;
> +               brcm,bt-pcm-int-params = [1 2 0 1 1];
>         };
>  };
> --
> 2.23.0
>
Looks mostly good.