Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191126212753.18455-1-pali.rohar@gmail.com>
In-Reply-To: <20191126212753.18455-1-pali.rohar@gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 27 Nov 2019 17:50:40 +0200
Message-ID: <CABBYNZ+X1xThm9rrcj7ny9f9r0sVs-fTR2JroQdRgZTRWLcN6g@mail.gmail.com>
Subject: Re: [PATCH] avctp: Set more descriptive name for uinput device
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Pali,

On Tue, Nov 26, 2019 at 11:31 PM Pali Roh=C3=A1r <pali.rohar@gmail.com> wro=
te:
>
> ---
>  profiles/audio/avctp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c
> index 70a3e40b2..ae53587ad 100644
> --- a/profiles/audio/avctp.c
> +++ b/profiles/audio/avctp.c
> @@ -1181,8 +1181,7 @@ static int uinput_create(char *name)
>         }
>
>         memset(&dev, 0, sizeof(dev));
> -       if (name)
> -               strncpy(dev.name, name, UINPUT_MAX_NAME_SIZE - 1);
> +       snprintf(dev.name, sizeof(dev.name), "Bluetooth Audio/Video Remot=
e Control%s%s", name ? " " : "", name ? name : "");
>
>         dev.id.bustype =3D BUS_BLUETOOTH;
>         dev.id.vendor  =3D 0x0000;
> --
> 2.11.0

It is already setting a bustype to BUS_BLUETOOTH why do you need to
make it more specific, btw it needs to be limited to
UINPUT_MAX_NAME_SIZE. Id say if we want to make it declare the
connection type that probably something that needs to be encoded in
the bus itself, like BUS_BLUETOOTH_AVCTP, BUS_BLUETOOTH_HOG, etc.

--=20
Luiz Augusto von Dentz