Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2619275ybl; Sat, 7 Dec 2019 20:14:15 -0800 (PST) X-Google-Smtp-Source: APXvYqx87WBfMImPxsMaT4LCDyiSkxytJjlVmmnJpSJoeWrUwYY0T7js22/7vk8GWykG9gQOqIIc X-Received: by 2002:a05:6830:10a:: with SMTP id i10mr16304657otp.365.1575778455415; Sat, 07 Dec 2019 20:14:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575778455; cv=none; d=google.com; s=arc-20160816; b=f78RbAKbX33CJnmkiYWQxoOE0GwVS9eZyQ3KTVKeWLNp9Se5pkyLk7qqIfukz3OZcj mGMOTYLFdb/WvDwl0ePErJGfDyxeHJI+NgSb3UdbEBQVfbCuVnnP1XK09z1g1JbAtRku Fxl7ul2JY/9eHKiSRXy86aXugK5eM0VaN/h+eyxIMGqJvAOB+BX2MAvP4ofTlYDOyIgG s0nZGOTNZvzrDw/b85PAEKpyo4JjqwbquhyCsvJ11P00JO6gnLnLeSU2iDlPmlV+trTC SQBkbHAvx0H6MKJyIx4tDVOXNho45dYK0csHaAAJf33le3gg44mo+j3wevnHP8VLZ6tu l14w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=qoU+TzXI1T/jxVp6DkRd5FCE6Lv/eR23QggHUbmn1xo=; b=c2TWAF6uZynu0tedZIJ7x+JLxFFvsv3LGED3FZKhmW4ZihXndVNU5wZWu/W5pgQ5GX fziaYom7/6NTOBP3M0VyMXZLaYd4xKsD0+MvoLIoJOWAfgvQ2+8dzE7FaFhGo56CwlL/ /DV+JLztTovKtDTd61vRtCED9SqGq0jQhoc/a+MnJNj/14+8SKedqJXvgaW1nib1/J4H ROEM4/fjZahaIbN4tNVPcqRRHmgaU/lcLxE6Mmi2anC5e4snq7G98weYgxrcSmzFOnD3 2NXDTsL0k71lrg3yLIZhf8Kd1QKJF7uUatoGlRmzbd66ae5pkjBZcrFxcaAuxaty7+R0 aeKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ce2TRY82; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n8si10404868otr.102.2019.12.07.20.13.39; Sat, 07 Dec 2019 20:14:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ce2TRY82; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726421AbfLHEL7 (ORCPT + 99 others); Sat, 7 Dec 2019 23:11:59 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:33273 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbfLHEL7 (ORCPT ); Sat, 7 Dec 2019 23:11:59 -0500 Received: by mail-oi1-f194.google.com with SMTP id v140so3503256oie.0 for ; Sat, 07 Dec 2019 20:11:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qoU+TzXI1T/jxVp6DkRd5FCE6Lv/eR23QggHUbmn1xo=; b=Ce2TRY82pqmfqi0LTvm2HPjTcbQkJn2Ig2BCMZTqOh+EJepbJaB5Xn9PUPw6wcECD3 yWfeggC1yS69tFIk46s8b5uILKcdw2Wb5fMli6g1Ac6op+3Hb1W8N+/LXLcg6XPYvmdt O0DHgHTuh76PWzvVD+ujxbC4wpwzVcmpBV24m+SHoSTSh2ezV0IPygPPl1nuM37YFXi1 EjJ9Pg1v9IHxQTs8UecMpTa50wq4HWwrWTKavttsob6STxj9HCR8LLlpTsEJxBulgARb 7F/xWbo9x4EjpUZUuHdcUmL/OYwhwPSx44kfOyN/jSG+udxOrcKpOOpIWkjLtmEmLvve Ff5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qoU+TzXI1T/jxVp6DkRd5FCE6Lv/eR23QggHUbmn1xo=; b=pczjCvfsLPGmDSC62ouLc3a0CfhngJZg4XiMNB4aky4iduXGw240OOxJN1LbMi1VML xvK5neU73M/S75Z/8UN52ww+vFS3/NpzIL0sycVNoONSR8L/CmkA142WBXiKDzqp4po5 8nDdgyjtOXisBWDB4umppsqcPqDQtdfrbvx9K5iDHiUglqjGOI2XDAc/UttRBrOFvjUJ bJjVRav+4IfWB9z9RWyYFttw6YiNGNxhOyxIs/bh4ZkXxnUklJUUbH/CmnnfQHHEvSLL OZqtaUQsL1whT5AoYoAEre9DdwT2FvZDjFVE4ut+oiWMS0YUVQkzVrwmmbl6N1ebGSAe 0DsA== X-Gm-Message-State: APjAAAWeeXxdyZbaDrF6Sov6RH+2As1wDYxEjFtE11jtzUE8XP7Baj+o JBLWNYrThdaGUUTU0D/0RRv9q5PSR/WwcL0axVYZm8L0 X-Received: by 2002:a54:4f8e:: with SMTP id g14mr3056942oiy.8.1575778318610; Sat, 07 Dec 2019 20:11:58 -0800 (PST) MIME-Version: 1.0 References: <1575366522-7742-1-git-send-email-s.syam@samsung.com> In-Reply-To: <1575366522-7742-1-git-send-email-s.syam@samsung.com> From: Luiz Augusto von Dentz Date: Sun, 8 Dec 2019 06:11:46 +0200 Message-ID: Subject: Re: [PATCH 1/1] client: Fix memory leak To: Syam Sidhardhan Cc: "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Syam, On Tue, Dec 3, 2019 at 11:51 AM Syam Sidhardhan wrote: > > --- > client/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/client/main.c b/client/main.c > index 68dabda..8bd0bac 100644 > --- a/client/main.c > +++ b/client/main.c > @@ -1792,11 +1792,11 @@ static void remove_device(GDBusProxy *proxy) > { > char *path; > > - path = g_strdup(g_dbus_proxy_get_path(proxy)); > - > if (!default_ctrl) > return; > > + path = g_strdup(g_dbus_proxy_get_path(proxy)); > + > if (g_dbus_proxy_method_call(default_ctrl->proxy, "RemoveDevice", > remove_device_setup, > remove_device_reply, > -- > 2.7.4 Applied, thanks. -- Luiz Augusto von Dentz