Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2788528ybl; Sun, 8 Dec 2019 00:40:33 -0800 (PST) X-Google-Smtp-Source: APXvYqwITO3DFbsFHHl9dMFyQh0rKxVb9LzQVbhcnO6ePFK2N21jONzekceXRJRDhGfz1woyQYqo X-Received: by 2002:a05:6808:14:: with SMTP id u20mr14746661oic.118.1575794433103; Sun, 08 Dec 2019 00:40:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575794433; cv=none; d=google.com; s=arc-20160816; b=NfD59cmeoi0uPCC3dl3cKvSHn/TQbYa5rSiQiyih8iY/0rZYyu182NBWiwxS0UcFmP 7+/g70a2uk7ZGfRIdUPDrD+TSIZDVqvGfTzt+RIGgyouBMjdjVlKkpGUfOc1NaE6ViT/ U6UEKFTL/O+QIfy54dRRIp/BvU/iyVjOQeQ231Gi93uHnszNiOSOOTxHA/WLP6Z1vgIK cf6t97wYjZSPMZjBX4AK5JRldZZA/ZNEQDiSbpmzJPo2H92ANaY8DsPm4o8KxRXB33J+ 5Z0J9Igg6l/i2bFATSmuv35KgegLHQKJH6kl1RSRGBnoDA3lg5BLfvOjNNo9nBti/37Z h22A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=sjJMm/zQXHjRYQxtQe2VjgIph5f8DK0R04jynkdt3d4=; b=lO7uM92KNfNX6IoCp/DLFE09u5bqpj6IGPhSPNiIKW/FlHUGFNSjWW8oLvRORtPr6k 1OXd9N8wpmbuUtesDQHmJepaFax/sL9wFw/MAF7WHfPi4wL1CX57QQCs8ke5acEjeled kGlMbrMQ1vXTsXxlMgnwzdMbohAQ6Ge1L8pwNswvIcuPm7u74KhIQb4J5Wvc2VD7aw4N MeOzBCvPVSotqevuyPfCm6vZyOITgrA/TF8znZpIjz8jrpnidUsk3Jg2Gq1swt2t0RCu PFTXQZ5WAOnAeH1+771qg3EP+o8BItTvGyzJjcZDRpwzXHxaGlNN0dC8ujlatSkjaZ2K yscA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v20si10218846oia.159.2019.12.08.00.40.01; Sun, 08 Dec 2019 00:40:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725860AbfLHIbp convert rfc822-to-8bit (ORCPT + 99 others); Sun, 8 Dec 2019 03:31:45 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:46390 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfLHIbp (ORCPT ); Sun, 8 Dec 2019 03:31:45 -0500 Received: from marcel-macbook.holtmann.net (p4FF9F0D1.dip0.t-ipconnect.de [79.249.240.209]) by mail.holtmann.org (Postfix) with ESMTPSA id 001E1CED09; Sun, 8 Dec 2019 09:40:53 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) Subject: Re: [PATCH] Fixing checkpatch noise. No functional changes. From: Marcel Holtmann In-Reply-To: <20191205182009.154769-1-alainm@chromium.org> Date: Sun, 8 Dec 2019 09:31:42 +0100 Cc: Bluez mailing list Content-Transfer-Encoding: 8BIT Message-Id: <62BE0838-4EF4-41EE-B3D5-90FDE9871D39@holtmann.org> References: <20191205182009.154769-1-alainm@chromium.org> To: Alain Michaud X-Mailer: Apple Mail (2.3601.0.10) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Alain, > --- > include/net/bluetooth/hci_core.h | 31 +++++++------ > include/net/bluetooth/mgmt.h | 6 +-- > net/bluetooth/hci_core.c | 45 +++++++++--------- > net/bluetooth/mgmt.c | 49 ++++++++++++-------- > net/bluetooth/smp.c | 78 ++++++++++++++++---------------- > 5 files changed, 114 insertions(+), 95 deletions(-) can you please break these down into some logical chunks and include the checkpatch complaint in the commit message. None of these look like fundamental style violation. I am happy to take these kind of patches, but sometimes we do ignore checkpatch since the code itself is perfectly fine a human to read. Regards Marcel