Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5289983ybl; Tue, 10 Dec 2019 03:41:43 -0800 (PST) X-Google-Smtp-Source: APXvYqwFqqUmltz/ZAcRoAyvFG7TK358Tdky0VUefElVL5yUHvCBatWzBLImMVFAwytwxBJFWMAD X-Received: by 2002:a05:6830:139a:: with SMTP id d26mr26134164otq.75.1575978103724; Tue, 10 Dec 2019 03:41:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575978103; cv=none; d=google.com; s=arc-20160816; b=sbh51reacDFSPn/ITS8jG4E8OQtHwSccjWNJb+OXSfjXtLDfhEsIA6gM7uJQLGSvFJ f82XAKXmfjOEnGPHpbJJS6Wnr7RUZBw4ATv6qEnpt5vLF1oy9zP60q0aLUIAkp2Hucun e7/P0pMljBCiN4cZ/Pae7bwHT2/sECoa4+7VyxG3pNMceGhQINIWaWwAAbBGli2spRFM GZ2fPAEFebLFKmhQ6vMiSZUKfbN3spbrgxysiVjjqzFNtVU/0boOSbKcn+ojjAubD5am PCtDgiwR0JBH6NnSXoejYViaUMkMNEblop5XvKB38ECXFDD0r/0FA7MD5FGt07qPRiUV e4ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from; bh=wOBQp4WP9RvFMmpuIU3LAo/8pMF5Ep4vML0E2YQu+KE=; b=sIwWaFpZ3fja/U0jbR8xT0jJy7dTyllRje0XXBpmcr8rq6h9UdO7fko0xaZRIjqX0w vUmCERhLKe3D4/VaxG5gSlDT03rsxNFuV8wLCdiN6whpOPvR4lU+71NZ24OJZlkL7zNX Qw+yAhXvhzdRCZuUUg/4TApsDSmXnry1YMmCmZJvPyHlXUdyc2Cbfak06LULBcNhzqIh 3CB85TQsbjfBt9+LKB7HI5BV3t6lFKjMuDKJj+bwv8walQlXIjeXRtUt7X6xuvf0oXZ7 3775ZBJv85y8GyEJmWGjj0QffPoAgAbXjxnuuRHapWsWfsDwPY8PdTLJovWzFln3grg9 UU3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d13si1722347ote.242.2019.12.10.03.41.26; Tue, 10 Dec 2019 03:41:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727259AbfLJLlW (ORCPT + 99 others); Tue, 10 Dec 2019 06:41:22 -0500 Received: from mga07.intel.com ([134.134.136.100]:28846 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727116AbfLJLlW (ORCPT ); Tue, 10 Dec 2019 06:41:22 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Dec 2019 03:41:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,299,1571727600"; d="scan'208";a="210420787" Received: from unknown (HELO ajay-desktop.iind.intel.com) ([10.223.96.133]) by fmsmga008.fm.intel.com with ESMTP; 10 Dec 2019 03:41:20 -0800 From: Ajay Kishore To: linux-bluetooth@vger.kernel.org Subject: [PATCH 1/5] obexd: Add initial support for MAP conversations Date: Tue, 10 Dec 2019 16:46:57 +0530 Message-Id: <1575976621-11019-1-git-send-email-ajay.kishore@intel.com> X-Mailer: git-send-email 2.7.4 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Changes made to add a new method for MAP conversation listing i.e "ListConversations" to handle conversation listing object "x-bt/MAP-convo-listing". Co-authored-by: Bharat Bhusan Panda Signed-off-by: Ajay Kishore --- obexd/client/map.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/obexd/client/map.c b/obexd/client/map.c index 550c5af..57ca77e 100644 --- a/obexd/client/map.c +++ b/obexd/client/map.c @@ -54,6 +54,7 @@ #define MAP_INTERFACE "org.bluez.obex.MessageAccess1" #define MAP_MSG_INTERFACE "org.bluez.obex.Message1" +#define MAP_CONV_INTERFACE "org.bluez.obex.Conversation1" #define ERROR_INTERFACE "org.bluez.obex.Error" #define MAS_UUID "00001132-0000-1000-8000-00805f9b34fb" @@ -1560,6 +1561,69 @@ static DBusMessage *map_list_messages(DBusConnection *connection, return get_message_listing(map, message, folder, apparam); } +static GObexApparam *parse_conversation_filters(GObexApparam *apparam, + DBusMessageIter *iter) +{ + DBusMessageIter array; + + if (dbus_message_iter_get_arg_type(iter) != DBUS_TYPE_ARRAY) { + DBG("Not of type array"); + return NULL; + } + + dbus_message_iter_recurse(iter, &array); + + while (dbus_message_iter_get_arg_type(&array) == DBUS_TYPE_DICT_ENTRY) { + const char *key; + DBusMessageIter value, entry; + + dbus_message_iter_recurse(&array, &entry); + dbus_message_iter_get_basic(&entry, &key); + + dbus_message_iter_next(&entry); + dbus_message_iter_recurse(&entry, &value); + + /* TODO: Parse conversation filters */ + + dbus_message_iter_next(&array); + } + return apparam; +} + +static DBusMessage *map_list_conversations(DBusConnection *connection, + DBusMessage *message, + void *user_data) +{ + struct map_data *map = user_data; + const char *folder; + GObexApparam *apparam; + DBusMessageIter args; + + dbus_message_iter_init(message, &args); + + if (dbus_message_iter_get_arg_type(&args) != DBUS_TYPE_STRING) + return g_dbus_create_error(message, + ERROR_INTERFACE ".InvalidArguments", NULL); + + dbus_message_iter_get_basic(&args, &folder); + + apparam = g_obex_apparam_set_uint16(NULL, MAP_AP_MAXLISTCOUNT, + DEFAULT_COUNT); + apparam = g_obex_apparam_set_uint16(apparam, MAP_AP_STARTOFFSET, + DEFAULT_OFFSET); + + dbus_message_iter_next(&args); + + if (parse_conversation_filters(apparam, &args) == NULL) { + g_obex_apparam_free(apparam); + return g_dbus_create_error(message, + ERROR_INTERFACE ".InvalidArguments", NULL); + } + + /*TODO: Return conversation listing */ + return NULL; +} + static char **get_filter_strs(uint64_t filter, int *size) { char **list, **item; @@ -1817,6 +1881,10 @@ static const GDBusMethodTable map_methods[] = { GDBUS_ARGS({ "folder", "s" }, { "filter", "a{sv}" }), GDBUS_ARGS({ "messages", "a{oa{sv}}" }), map_list_messages) }, + { GDBUS_ASYNC_METHOD("ListConversations", + GDBUS_ARGS({ "folder", "s" }, { "filter", "a{sv}" }), + GDBUS_ARGS({ "conversations", "a{oa{sv}}" }), + map_list_conversations) }, { GDBUS_METHOD("ListFilterFields", NULL, GDBUS_ARGS({ "fields", "as" }), -- 2.7.4