Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1575976621-11019-1-git-send-email-ajay.kishore@intel.com> <1575976621-11019-5-git-send-email-ajay.kishore@intel.com>
In-Reply-To: <1575976621-11019-5-git-send-email-ajay.kishore@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 10 Dec 2019 21:53:52 +0200
Message-ID: <CABBYNZLH1qxYELgf4CV0PVb9Lcw1FM5X=TH8ikuMC4FcyJjWzA@mail.gmail.com>
Subject: Re: [PATCH 5/5] obexd: Handle MAP Event Report v1.1 and v1.2
To:     Ajay Kishore <ajay.kishore@intel.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Ajay,

On Tue, Dec 10, 2019 at 1:42 PM Ajay Kishore <ajay.kishore@intel.com> wrote:
>
> Changes made to add handler function for the corresponding
> events mentioned in extended event reports 1.1 and 1.2.
>
> Signed-off-by: Ajay Kishore <ajay.kishore@intel.com>
> ---
>  obexd/client/map-event.h |  8 +++++++-
>  obexd/client/map.c       | 24 ++++++++++++++++++++++++
>  2 files changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/obexd/client/map-event.h b/obexd/client/map-event.h
> index 5414b26..c41bb67 100644
> --- a/obexd/client/map-event.h
> +++ b/obexd/client/map-event.h
> @@ -32,7 +32,13 @@ enum map_event_type {
>         MAP_ET_MEMORY_FULL,
>         MAP_ET_MEMORY_AVAILABLE,
>         MAP_ET_MESSAGE_DELETED,
> -       MAP_ET_MESSAGE_SHIFT
> +       MAP_ET_MESSAGE_SHIFT,
> +       MAP_ET_READ_STATUS_CHANGED,
> +       MAP_ET_MESSAGE_REMOVED,
> +       MAP_ET_MESSAGE_EXTENDED_DATA_CHANGED,
> +       MAP_ET_PARTICIPANT_PRESENCE_CHANGED,
> +       MAP_ET_PARTICIPANT_CHAT_STATE_CHANGED,
> +       MAP_ET_CONVERSATION_CHANGED
>  };
>
>  struct map_event {
> diff --git a/obexd/client/map.c b/obexd/client/map.c
> index b65131a..b1b4b38 100644
> --- a/obexd/client/map.c
> +++ b/obexd/client/map.c
> @@ -2550,6 +2550,17 @@ static void map_handle_folder_changed(struct map_data *map,
>                                                                 "Folder");
>  }
>
> +static void map_handle_remove_message(struct map_data *map,
> +                                               struct map_event *event)
> +{
> +       struct map_msg *msg;
> +
> +       msg = g_hash_table_lookup(map->messages, &event->handle);
> +
> +       if (msg)
> +               g_hash_table_remove(map->messages, &event->handle);

I believe you only need the call to remove here otherwise we might
just be doing 2 lookups for no obvious reason since remove already
does that.

> +}
> +
>  static void map_handle_notification(struct map_event *event, void *user_data)
>  {
>         struct map_data *map = user_data;
> @@ -2582,6 +2593,19 @@ static void map_handle_notification(struct map_event *event, void *user_data)
>         case MAP_ET_MESSAGE_SHIFT:
>                 map_handle_folder_changed(map, event, event->folder);
>                 break;
> +       case MAP_ET_READ_STATUS_CHANGED:
> +               map_handle_status_changed(map, event, "read");
> +               break;
> +       case MAP_ET_MESSAGE_REMOVED:
> +               map_handle_remove_message(map, event);
> +               break;
> +       case MAP_ET_MESSAGE_EXTENDED_DATA_CHANGED:
> +               map_handle_status_changed(map, event,
> +                                       "message-extended-data-changed");
> +               break;
> +       case MAP_ET_PARTICIPANT_PRESENCE_CHANGED:
> +       case MAP_ET_PARTICIPANT_CHAT_STATE_CHANGED:
> +       case MAP_ET_CONVERSATION_CHANGED:
>         case MAP_ET_MEMORY_FULL:
>         case MAP_ET_MEMORY_AVAILABLE:
>         default:
> --
> 2.7.4
>


-- 
Luiz Augusto von Dentz