Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "=?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek" 
        <michal.lowas-rzechonek@silvair.com>
Date:   Wed, 11 Dec 2019 16:48:23 +0100
To:     Inga Stotland <inga.stotland@intel.com>
Cc:     linux-bluetooth@vger.kernel.org, brian.gix@intel.com
Subject: Re: [PATCH BlueZ 2/3] mesh: Clean up node.c
Message-ID: <20191211154823.b4hwkqor5awnxpat@mlowasrzechonek2133>
Mail-Followup-To: Inga Stotland <inga.stotland@intel.com>,
        linux-bluetooth@vger.kernel.org, brian.gix@intel.com
References: <20191206205749.12918-1-inga.stotland@intel.com>
 <20191206205749.12918-3-inga.stotland@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191206205749.12918-3-inga.stotland@intel.com>
User-Agent: NeoMutt/20180716
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Inga,

On 12/06, Inga Stotland wrote:
> @@ -876,8 +902,6 @@ uint16_t node_generate_comp(struct mesh_node *node, uint8_t *buf, uint16_t sz)
>  {
>  	uint16_t n, features;
>  	uint16_t num_ele = 0;
> -	uint8_t *cfgmod_idx = NULL;
> -
>  	const struct l_queue_entry *ele_entry;
>  
>  	if (!node || !node->comp || sz < MIN_COMP_SIZE)
> @@ -940,9 +964,6 @@ uint16_t node_generate_comp(struct mesh_node *node, uint8_t *buf, uint16_t sz)
>  			mod_id = mesh_model_get_model_id(
>  					(const struct mesh_model *) mod);
>  
> -			if (mod_id == CONFIG_SRV_MODEL)
> -				cfgmod_idx = &ele->idx;
> -
>  			if ((mod_id & VENDOR_ID_MASK) == VENDOR_ID_MASK) {
>  				if (n + 2 > sz)
>  					goto element_done;
> @@ -988,9 +1009,6 @@ element_done:
>  	if (!num_ele)
>  		return 0;
>  
> -	if (!cfgmod_idx || *cfgmod_idx != PRIMARY_ELE_IDX)
> -		return 0;
> -
>  	return n;
>  }

Note that this cause the daemon to no longer reject applications that
declare presence of Config Server Model on non-primary element.

-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND