Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200102172447.18574-1-luiz.dentz@gmail.com> <20200102172447.18574-2-luiz.dentz@gmail.com>
 <DM5PR14MB1385EC175428FE2F702258FEE6230@DM5PR14MB1385.namprd14.prod.outlook.com>
In-Reply-To: <DM5PR14MB1385EC175428FE2F702258FEE6230@DM5PR14MB1385.namprd14.prod.outlook.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 3 Jan 2020 09:45:15 -0800
Message-ID: <CABBYNZ+3A7qf6X6oLgV3FXOQbDYo5H52V6Ui_0R+WEM0sktGqw@mail.gmail.com>
Subject: Re: [RFC 2/2] Bluetooth: Add BT_PHYS socket option
To:     Jamie Mccrae <Jamie.Mccrae@lairdconnect.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Jamie,

On Thu, Jan 2, 2020 at 11:22 PM Jamie Mccrae
<Jamie.Mccrae@lairdconnect.com> wrote:
>
> > diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> > index e42bb8e03c09..69c0e7eb26d9 100644
> > --- a/include/net/bluetooth/bluetooth.h
> > +++ b/include/net/bluetooth/bluetooth.h
> > @@ -121,6 +121,23 @@ struct bt_voice {
> >
> >  #define BT_SNDMTU              12
> >  #define BT_RCVMTU              13
> > +#define BT_PHYS                        14
> > +
> > +#define BT_PHY_BR_1M_1SLOT     0x00000001
> > +#define BT_PHY_BR_1M_3SLOT     0x00000002
> > +#define BT_PHY_BR_1M_5SLOT     0x00000004
> > +#define BT_PHY_EDR_2M_1SLOT    0x00000008
> > +#define BT_PHY_EDR_2M_3SLOT    0x00000010
> > +#define BT_PHY_EDR_2M_5SLOT    0x00000020
> > +#define BT_PHY_EDR_3M_1SLOT    0x00000040
> > +#define BT_PHY_EDR_3M_3SLOT    0x00000080
> > +#define BT_PHY_EDR_3M_5SLOT    0x00000100
> > +#define BT_PHY_LE_1M_TX                0x00000200
> > +#define BT_PHY_LE_1M_RX                0x00000400
> > +#define BT_PHY_LE_2M_TX                0x00000800
> > +#define BT_PHY_LE_2M_RX                0x00001000
> > +#define BT_PHY_LE_CODED_TX     0x00002000
> > +#define BT_PHY_LE_CODED_RX     0x00004000
>
> My query about this is there is an option for LE Coded, but LE coded can have a data rate of 125Kbps or 500Kbps, is there no need to differentiate between the two rates in applications?

I guess you referring to L=2 and L=8 payloads, those are unfortunately
not exposed over HCI, they seem to be tied to LL power control and not
with the PHY selection so Im not sure how we would be able to infer
what payload is in use. Btw, I've the PHY bit fields to match what we
use in the management socket,


-- 
Luiz Augusto von Dentz