Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
Subject: Re: OCF_READ_LOCAL_CODECS is permitted only for root user
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20191228171212.56anj4d4kvjeqhms@pali>
Date:   Sat, 4 Jan 2020 10:44:52 +0100
Cc:     linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <45BB2908-4E16-4C74-9DB4-8BAD93B42A21@holtmann.org>
References: <20191228171212.56anj4d4kvjeqhms@pali>
To:     =?utf-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Pali,

> I wrote a simple script "sco_features.pl" which show all supported
> codecs by local HCI bluetooth adapter. Script is available at:
> 
> https://github.com/pali/hsphfpd-prototype/blob/prototype/sco_features.pl
> 
> And I found out that OCF_READ_LOCAL_CODECS HCI command cannot be send by
> non-root user. Kernel returns "Operation not permitted" error.
> 
> What is reason that kernel blocks OCF_READ_LOCAL_CODECS command for
> non-root users? Without it (audio) application does not know which
> codecs local bluetooth adapter supports.
> 
> E.g. OCF_READ_LOCAL_EXT_FEATURES or OCF_READ_VOICE_SETTING commands can
> be send also by non-root user and kernel does not block them.

actually the direct access to HCI commands is being removed. So we have no plans to add new commands into the list since that it what the kernel is suppose to handle. If we wanted to expose this, then it has to be via mgmt.

Regards

Marcel