Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp19463936ybl; Sat, 4 Jan 2020 01:58:17 -0800 (PST) X-Google-Smtp-Source: APXvYqxy37nJfHO6vznQYxmsFRv1BZGc8UQX9PqLSbz8VOkpNpV93PqZGJvTeF45FON487mFYA8z X-Received: by 2002:a9d:65cf:: with SMTP id z15mr106962154oth.238.1578131897736; Sat, 04 Jan 2020 01:58:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578131897; cv=none; d=google.com; s=arc-20160816; b=xrff2LuxDRU/2dLTtJenNMNaPfg2weCu1W61fuT73uU5no68pRw4Y6DVE+Ri64QKQ0 6vY7tg8k7v8x6PMCSBMaUp8w+j9H2LRpP4UfiMmeULn/hIkAJOp5A10KF9n34wUhFbxL byvtXL3xdsxngNeoe4gcOTAwodhNDPejVXJan4TFP6KUcjjmCdscubOYCtZkpUYfuC8j 3tzIQUoN/mZLV+23nns59SjrtyrYAfs4ql65oH5GsYLIWmziQs1qpICpjrPoqBQrjTys +Imz6hXjRs9IOpewsBqbxVu4Vcecx9/E3sbYw+9o8vkRmm1UQkIf2a8fb5Eifx8/59Jw 7Qyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=L23w//su/gCpcb2PFrIItDJjL5pESvGfrmS6X49PEEo=; b=dZu00S+obpD7JwUKyjwotZuzwHtGOmdCvIo0LhzsJjRdkVVF1O+p9+BxNVlDhBZJXJ 3R/qs8E2J7iFm3g7bkkFWwXwbUthnfLKYaWs9rzWUNrmLT57yhU7jq1x7XgIhM0NGTka vi0KpJMiu28DY+3Z0Jo/3Y5KJiFXMD6ODFjN1qxbHAx90fZGfMTP2wE7M1GmqiXBz75R P0dVaoXRAr+Ww68B+Tey0ZhWuWbfh0nqgujgq5r9wEVMg8kpNkoC5dx+dm25Rbb3eSee lCfiNm/DzI6g5mBQl1BHqkvAP+9ttopzRbuoFagET5PbxU73VoaXhcgNIxc1jbLiz2Sa QwWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h9si28940946oia.97.2020.01.04.01.58.06; Sat, 04 Jan 2020 01:58:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726275AbgADJ6E convert rfc822-to-8bit (ORCPT + 99 others); Sat, 4 Jan 2020 04:58:04 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:37866 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbgADJ6E (ORCPT ); Sat, 4 Jan 2020 04:58:04 -0500 Received: from marcel-macbook.fritz.box (p4FEFC5A7.dip0.t-ipconnect.de [79.239.197.167]) by mail.holtmann.org (Postfix) with ESMTPSA id 99ECFCED12; Sat, 4 Jan 2020 11:07:18 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: Re: [PATCH v6 2/2] bluetooth:btusb: handle msbc audio over USB Endpoints From: Marcel Holtmann In-Reply-To: <20191205083229.29890-1-sathish.narasimman@intel.com> Date: Sat, 4 Jan 2020 10:58:02 +0100 Cc: BlueZ devel list , Sathish Narasimman , Chethan T N , Hsin-Yu Chao , Amit K Bag Content-Transfer-Encoding: 8BIT Message-Id: References: <20191205083229.29890-1-sathish.narasimman@intel.com> To: Sathish Narsimman X-Mailer: Apple Mail (2.3608.40.2.2.4) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Sathish, > For msbc encoded audio stream over usb transport, btusb driver > to be set to alternate settings 6 as per BT core spec 5.0. The > type of air mode is used to differenting which alt setting to be > used. > The changes are made considering some discussion over the similar > patch submitted earlier from Kuba Pawlak(link below) > https://www.spinics.net/lists/linux-bluetooth/msg64577.html > > Reported-by: kbuild test robot > Signed-off-by: Sathish Narasimman > Signed-off-by: Chethan T N > Signed-off-by: Hsin-Yu Chao > Signed-off-by: Amit K Bag > --- > drivers/bluetooth/btusb.c | 157 +++++++++++++++++++++++++++++--------- > 1 file changed, 121 insertions(+), 36 deletions(-) I would really prefer to have some Tested-by lines from people that can verify that this patch works. Luiz, do we. Need to address further details for mSBC support? Regards Marcel