Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
Subject: Re: [PATCH 5/8] net: bluetooth: remove unneeded MODULE_VERSION()
 usage
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20200104195131.16577-5-info@metux.net>
Date:   Sun, 5 Jan 2020 10:34:56 +0100
Cc:     lkml <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc,
        sven@narfation.org, Johan Hedberg <johan.hedberg@gmail.com>,
        roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
        edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
        jon.maloy@ericsson.com, ying.xue@windriver.com, kafai@fb.com,
        songliubraving@fb.com, yhs@fb.com, andriin@fb.com,
        netdev <netdev@vger.kernel.org>,
        BlueZ devel list <linux-bluetooth@vger.kernel.org>,
        tipc-discussion@lists.sourceforge.net,
        linux-hyperv@vger.kernel.org, bpf@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <22BD3D36-DE54-4062-B3A1-15D9E0E256A8@holtmann.org>
References: <20200104195131.16577-1-info@metux.net>
 <20200104195131.16577-5-info@metux.net>
To:     "Enrico Weigelt, metux IT consult" <info@metux.net>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Enrico,

> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.

I prefer to keep the MODULE_VERSION info since it provides this information via modinfo.

Unless there is a kernel wide consent to remove MODULE_VERSION altogether, the Bluetooth subsystem is keeping it.

Regards

Marcel