Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "=?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek" 
        <michal.lowas-rzechonek@silvair.com>
Date:   Wed, 8 Jan 2020 19:17:58 +0100
To:     "Gix, Brian" <brian.gix@intel.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "rafal.gajda@silvair.com" <rafal.gajda@silvair.com>
Subject: Re: [PATCH BlueZ] mesh: Fix IV recovery
Message-ID: <20200108181758.kkgjtqkom4kuvzih@kynes>
Mail-Followup-To: "Gix, Brian" <brian.gix@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "rafal.gajda@silvair.com" <rafal.gajda@silvair.com>
References: <20200108091604.15185-1-rafal.gajda@silvair.com>
 <89614c82891524958af2a7c75c1792b0c9ca4467.camel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <89614c82891524958af2a7c75c1792b0c9ca4467.camel@intel.com>
User-Agent: NeoMutt/20180716
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Brian, Rafał,

On 01/08, Gix, Brian wrote:
> > -	if (ivu != net->iv_update || local_iv_index != net->iv_index) {
> > +	if (ivu != net->iv_update || iv_index != net->iv_index) {
> 
> Would it be fair to say that this is the *only* change to the code that fixes the logic that was
> malfunctioning?

That's correct.

> 
> If so, I would like to shrink this patch to just:
> 
> -	if (ivu != net->iv_update || local_iv_index != net->iv_index) {
> +	if (ivu != local_ivu || iv_index != local_iv_index) {
>
> or, breaking this into a 2-patch patchset, where one of the patches removes the local caching of ivu and ivi,
> and the second patch fixes the actual bug.

Ok, let's split this into 2 separate patches. I still think this "local
caching" was the underlying cause of the mistake.

regards
-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND