Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2459743ybl; Thu, 9 Jan 2020 13:10:07 -0800 (PST) X-Google-Smtp-Source: APXvYqyEsg+kzWvvnj9bzQxnSEMBZHSWoSsNakCZqBUY1ZazLSudx8Tg1ZRe/kH9OCyU5kcH0L5Q X-Received: by 2002:a9d:798e:: with SMTP id h14mr9619245otm.257.1578604207044; Thu, 09 Jan 2020 13:10:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578604207; cv=none; d=google.com; s=arc-20160816; b=G0VFCTUwBXXsLILUFEkWDoOf9nwGTRnhOxMj814UFO7VQFyEtGb6GRajLfC55s1ajm ml3bbIG333WRGZjM+JQy0/Hw0BLFqiQrlSWeaCPtoV3DR5HKcQMIkzGGsj57rW07++SY /esAf2VUfrqONrgFP28PgqXh4qQu6kKz5pd1iIjb+fNaC3C1bUCG5mmYySM+Fl6cIYv1 HGr1/a2tDCbcCiEScGbNKIcdqaZHyTPKcNjG6kxtOXbUJeEmZlM38a59gu7ToAu4sDqG Q5YChVaZ9qJECzQWmHQoJfPShdOAvk7RCAtgOjrnJ6xWTeQsZ4o7UTRP8Kh4yyT/if4Y sUEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:date:from :dkim-signature; bh=FTW9jIYcLQMb7e9oKW1p6IjvJ4YaMuR5pJ9pkgM2jAs=; b=uwQkw4J/pbORpx4O7lz5U6ym9P4rc7xRntcWlp0+6IovkHg3oDUxlRXjDsh60+BAXF CBpB3AvuDIFbVpGN9dXB0RBagypraS15hgKUSSOeuDXlzZzBiX9kuYqRgYRLYnAHUcDe +IZKkGdorYH57jgbVToguxsN6MrdIHyBzfxaWWXFLSM+YBjihF9hSl3svA+tYp9bIPtH gEspkDui1/LA6EYuTdx6XlKqE+4V1dDaWc+YtP/PkbHhZ1WrvDnosAvWOEXyWg3KEwVm wnzaynBebFUhi/rWrSoUjQxrSEp7sC9/V0YkByHmVHb38MSSTEffQJXpSPD8EJOznEB0 augQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=SlHdxpA3; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i10si4900360otr.272.2020.01.09.13.09.54; Thu, 09 Jan 2020 13:10:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=SlHdxpA3; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725840AbgAIVIl (ORCPT + 99 others); Thu, 9 Jan 2020 16:08:41 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:37351 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbgAIVIl (ORCPT ); Thu, 9 Jan 2020 16:08:41 -0500 Received: by mail-lj1-f195.google.com with SMTP id o13so8764849ljg.4 for ; Thu, 09 Jan 2020 13:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silvair-com.20150623.gappssmtp.com; s=20150623; h=from:date:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=FTW9jIYcLQMb7e9oKW1p6IjvJ4YaMuR5pJ9pkgM2jAs=; b=SlHdxpA3LcTodJoHxXwoh1ZiSc4Rc/KnFVA+3qQ/NEXNs5Y8FR+cbbqvkq6dQzmy0i 248q72WGfJMxwhI2fhBnJg1ywwvIYw+iFLoXuoNceABwUPMu+kSOTilt60Ri8EVT8PNO 4csA0Uf86SP/q3HjpYuakdtpwVNz9aPEhy7UnyTvz28zuo8svoRT4OLMmWqufQtrVPn+ LYR7tn8rBivtplz18vF3q5DE8Q+klD47NgiFsuWk7ABMPXt/kqVTH9g1dCWF/3RfdzYE VKYGIDQJGofzwMAg7iIBo779E6tg22pAUJLbNc0TSd8soveBx1OPo74ZUUByQ4cnFTGM B1NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=FTW9jIYcLQMb7e9oKW1p6IjvJ4YaMuR5pJ9pkgM2jAs=; b=ropTMDP5hkzvnt5gFVvjrs08mat/1mSMHPoGazturBVFuJG/8LQrS3fOc1QdbHSMhR hT95VlM5V/i8rhqZ5fiLsWiHc4v068k14QvWgmbASFAfs7wQs7q8zdynEIY/Mpq/HaXM tnjzVoiZkLo+loEoCVR1Ug9hke3rS4jUPQd2ad554+TQ0w25EopgOy9heP7ZzRAYhlFU FbZIwmuvgfpAb4RT2v5lrZ1M2oovAC8VCCK8x1S6gm3coHn32OM5K2JentgAn4iFzRIE iZLfqNYprBv8eDD7mfz85+efLK3oGTHG+8Xt9Xt8o+MlxgpA08Ij9Z9oEDwDG1qEFJAK 7nIw== X-Gm-Message-State: APjAAAUSWcvcarlWHQioDv2cRbXq3d/OyASCwndE3aZaAzmRbUyHVr17 yv2gbMlc2jK/0K/P4d+b2tswzQ== X-Received: by 2002:a05:651c:1049:: with SMTP id x9mr1535ljm.233.1578604119653; Thu, 09 Jan 2020 13:08:39 -0800 (PST) Received: from kynes (apn-37-7-124-67.dynamic.gprs.plus.pl. [37.7.124.67]) by smtp.gmail.com with ESMTPSA id d20sm3548430ljg.95.2020.01.09.13.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2020 13:08:39 -0800 (PST) From: "=?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek" X-Google-Original-From: =?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek Date: Thu, 9 Jan 2020 22:08:37 +0100 To: Inga Stotland Cc: linux-bluetooth@vger.kernel.org, brian.gix@intel.com Subject: Re: [PATCH BlueZ] mesh: Correctly generate NetKey list Message-ID: <20200109210837.yraajvc76g4xv5oh@kynes> Mail-Followup-To: Inga Stotland , linux-bluetooth@vger.kernel.org, brian.gix@intel.com References: <20200109175715.22925-1-inga.stotland@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200109175715.22925-1-inga.stotland@intel.com> User-Agent: NeoMutt/20180716 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Inga, On 01/09, Inga Stotland wrote: > When responding with NetKey List Status, packed NetKey indices into > 3 octets per pair. If number of NetKeys is odd, append the last key > index as a 2-octet value. Another thing: doesn't this duplicate the same logic implemented in appkey.c function appkey_list? OP_APPKEY_LIST is (and was) working fine. -- Michał Lowas-Rzechonek Silvair http://silvair.com Jasnogórska 44, 31-358 Krakow, POLAND