Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8081369ybl; Thu, 16 Jan 2020 10:17:25 -0800 (PST) X-Google-Smtp-Source: APXvYqzj9WE7YInVbBNCyvryA0W3Eb/Id7lughKB3oLgJAxEKLCG4SPcFwChXHGffbY2fqNW87KN X-Received: by 2002:a9d:4692:: with SMTP id z18mr3061676ote.163.1579198645380; Thu, 16 Jan 2020 10:17:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579198645; cv=none; d=google.com; s=arc-20160816; b=Bl9AAcZJqaKLkpZFsX7J4WBo3UpaO46XVuYbUIbxqciUDK3yHVsQMiS7BXTbJdJx+F 3QNu11F+STlvje8fb5j1jkzfwmZAHi+sv4vYH7ZAgb5NY2YU47xw33zi+/7Tq+NaAXcz x5W7GkClevK/qWvlh0w1XoIFF0bWa6W06a68s2XaK6w6+qEU/NgKLyHzS5J5q+2lPNJw fMGjrSJH4EBbjpg702Pwp/MCQipT1uooogTKDrMSAg7T3Mi/WtuusaeK2YHWnDHKKdUf Ls8G5Pjz5orVKyq1JbUk5jqKV9c2JxkxO0hRxoyAkkUIoja+YSUykho7+nIVsV2Fno04 9qvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=8NOXEoIwyCfE3MSBNh+YfE5C2+yQ4Qu+EkGHXShP94I=; b=NL+V2YOrq0IwFI2WoTfAuI6L5Bg6IBIObVC7u69hp03wHBqXrlx50KvilII8ElDFfL OUrkvqmYvReCFH6NtvKLp8uDZO33LAmOduCk82EsF2sYd0h/fRGXDXnZMWRNIogTIFOS ouMyR5KJQrqhI/z8BFlEzbtoBP8qMlArAdRrsXJSbytnjDCuF1y2yZ62Xf+zc3cGaW8d +PKtBra9uESmoQwo3b5xglwJSCd1Si8/AB/mm6391xiY+54KRkFI1jageCbra/4gP0/F 2Njh+a2LOjPlzSrDaU7pSynvlQGtPvNbQLBnmqMU3YV9myh3QL83sJBZ665r/HW8za3V purA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b="Dm/Fo4mh"; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z1si13653850otq.21.2020.01.16.10.17.12; Thu, 16 Jan 2020 10:17:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b="Dm/Fo4mh"; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391118AbgAPSQj (ORCPT + 99 others); Thu, 16 Jan 2020 13:16:39 -0500 Received: from mail-lf1-f54.google.com ([209.85.167.54]:39064 "EHLO mail-lf1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436474AbgAPSQh (ORCPT ); Thu, 16 Jan 2020 13:16:37 -0500 Received: by mail-lf1-f54.google.com with SMTP id y1so16188853lfb.6 for ; Thu, 16 Jan 2020 10:16:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silvair-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8NOXEoIwyCfE3MSBNh+YfE5C2+yQ4Qu+EkGHXShP94I=; b=Dm/Fo4mhJmc+I3vWXVcD/syAm8hzMcOGii2NnjgzzTLD/lWRT9p1ZAKIvxNVZxpdJ6 CTo7dWDbAZhS2GxQa1Y/32V/LaD4rFL2Gf/3csVqBPooGSl8k5KfzI69Z9drhawwtSd6 7GHHlPzOdAHPj/BlgVlzQpF0f4g4sg9uIqS6e8+/jCaFzNM+mHkH6sMq7XGSAss2thL+ PPQihF1ONHfgyw3MQYa9HKoaY2OuLrhgNdZkdIGLgIv4rFnxhfyrgl3eqJXi1/mIgw9I MWXzmSqHeG/ZzF/1J1DFsN7/AHG7WPqZmhLRqI42t9DaR1RZkGYNxqN0ci3ROmT6Ni6F UyCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=8NOXEoIwyCfE3MSBNh+YfE5C2+yQ4Qu+EkGHXShP94I=; b=L4OV7o04r3DzY0Jq2Taxh/AXIVk9Pzq2LOag+Qw+ncEfW82l6/S9TF7v6fzKaPOjER 4RrC7YJSZxokjEYqtrGc2Q1OCkLWhb9XZXPh85cyv/hzjV5CYMpwTv9XqkcWiGyRv2ek fBIowTiSz2oqMiezxMvJPeaPe59dGkKtOFAZ6ej9LKpseWn72YXWfsfCv6HCxG0eE7Uf fJKe80OZW4CjYuHjPjUmTGZ4vcP44PT0inRQRLGm/XJBGaRuY+HFPwprH6WxwTpoXotp c5ogeLIt2pFel0xhFdxSkoC5edY8I0rRNEJRJJHJPoFYwkjf3wgVOoqJDERBLhAEKV9O vk7w== X-Gm-Message-State: APjAAAXk/yrVo28RNEfpfMvW+1M1PL4/ugjTUFVfuV8C0A2mtV0hiTVP sa3iTTFDUWA/wM+bxz4uuzOsUg== X-Received: by 2002:a19:dc1e:: with SMTP id t30mr3087588lfg.34.1579198595758; Thu, 16 Jan 2020 10:16:35 -0800 (PST) Received: from kynes (apn-5-60-0-97.dynamic.gprs.plus.pl. [5.60.0.97]) by smtp.gmail.com with ESMTPSA id a15sm11034380lfi.60.2020.01.16.10.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 10:16:35 -0800 (PST) Date: Thu, 16 Jan 2020 19:16:33 +0100 From: =?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek To: Brian Gix Cc: linux-bluetooth@vger.kernel.org, inga.stotland@intel.com, jakub.witowski@silvair.com Subject: Re: [PATCH BlueZ v3 0/1] mesh: Sequence number related fixes Message-ID: <20200116181633.rtda4hlxeidzmg54@kynes> Mail-Followup-To: Brian Gix , linux-bluetooth@vger.kernel.org, inga.stotland@intel.com, jakub.witowski@silvair.com References: <20200116163908.18041-1-brian.gix@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200116163908.18041-1-brian.gix@intel.com> User-Agent: NeoMutt/20180716 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Brian, Jakub, On 01/16, Brian Gix wrote: > Adjusted comments for clarity, Thank you. > and adjusted the cache-write code to not rewrite the NVM storage if > nothing has changed, to prevent NVM thrashing if we do reach the > out-of-range boundary True. > I would like both Michal and Jakub's comments on these adjustments. Thanks again, LGTM. -- Michał Lowas-Rzechonek Silvair http://silvair.com Jasnogórska 44, 31-358 Krakow, POLAND