Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4069951ybl; Tue, 21 Jan 2020 12:15:22 -0800 (PST) X-Google-Smtp-Source: APXvYqxb3caOsHaqPSy6Y7bAec1FaRolaoSz4Oa0h1gA2y8vOdhf/DOVLOXOaFx3CdCzKTPIk6J5 X-Received: by 2002:aca:c646:: with SMTP id w67mr4191983oif.171.1579637722024; Tue, 21 Jan 2020 12:15:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579637722; cv=none; d=google.com; s=arc-20160816; b=syKUAcXwpBGEf667Qfnt0bwJ6Nm2TLTSho9QAFeeeMco6l+bqBL9Xw9GOo06rq0Txc PRTciSy5oogge5aZh71+LmgLJNG/XkucDoq0L5T9b+1MaFwvELcbVt5KZsHLnrDvTJCE qWlARYGDa2Sb5BNLoNHeC18XMmpoivVi7FYQ78HVHYXX92oenuVExezckYLhFMm3pACr lgODuJWK29hxN45RD9SYAshP8NTL8IRSpZhHj896/2hMSMcXv0JX7Dg6I4sTvskgdTBf XcyRwjpAitvpn7GPDtrIQVIMBacoChuRrB09uX4y8PRkfl2yA3mAUCu/yjy/2Nj7yPKh qonw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=HbtJxsHTBL9KqztHKdKNEHpXofiAHjtU2iQrO0XNbKE=; b=x7qkK4JobXGLn6DUFAl0h45AABEgDZLBjNqnWijCK5uIQ+sML+mWvHFtmr3dK1eze9 2+QvdPoo4X94KcNvmD908R3CMhbZdqH8oXUQ61qX6DUF/BlPZ8Zv8RkTGoDMpBk85Mg4 EgX3cslXOGjA6xD1fiilyvzM8GN9uMxk904YbnIOg00V+eHh2fz5A5ZoGtmG5kCM2mfR NWJlrBmDEdH9D4ClvM+AVZZ4duPQmu4hEFNALv10UTZQ710pYljAF/swIhqMLk64y77T YXefnme/cDFY1jwTII3NDTX8jPAIpfmvkFh2bVhb9Yb4oL3icY2ZOKa0UYqwqRGQaiYz psEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=FuRnjyBT; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s20si22120815otq.28.2020.01.21.12.15.07; Tue, 21 Jan 2020 12:15:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=FuRnjyBT; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727360AbgAUUPG (ORCPT + 99 others); Tue, 21 Jan 2020 15:15:06 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:39199 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726926AbgAUUPG (ORCPT ); Tue, 21 Jan 2020 15:15:06 -0500 Received: by mail-lf1-f67.google.com with SMTP id y1so3391477lfb.6 for ; Tue, 21 Jan 2020 12:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silvair-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HbtJxsHTBL9KqztHKdKNEHpXofiAHjtU2iQrO0XNbKE=; b=FuRnjyBTT1rGpudQhTZV1yx4N46BT/nl+Z1mVD44xw5DwqeiWDIb9AYgNfbDAU7E1s isD9P7MZWJe6tFbgIpE1FrURodlGC8fKHTl0L6VbOv+njH3/+Xk4QlSjpaWqRKUR9Apv XTjHb5L7yTGpuxB8HqCzlKtEY1dCLOTKs0YA6AQgpkPoei9xjS6owIA2Mr/cWhlSsl5Z fD2RuAXn8GqTAK14FdzutBbhYLkntxYC0Z5Ji56o/bv9TnnHw8tplUX32yng8tmLKD7b rfcjGKoPefZaKNlM2JosuusaRdjD+EvcpsDfDObqFwHd9cjI8tg2Tmd5kUGSJPifn1Qc ntjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=HbtJxsHTBL9KqztHKdKNEHpXofiAHjtU2iQrO0XNbKE=; b=c03zAf5US1iUBi7ke1CSt9rDJzE2RSnma/54pC8qyWtmS32VjWH90bgM0b9kYy6nzJ sr9gqHyvELvFycUOAgWnvnmuMm1CCpd3VJtv0vyIqlDPG3kuGuY2qc0j3kzmZpjqd/db gM0OBENNHxjgCG473dp93YZcfZojnhWwjlPsiqXw40DUtENKKtm0ilHG37TtgJYzfYBh 2T51SHUko5iKikJaArawF6rCaUjMHjCbmd8jcs/dHsusd3zsa0Osa3UGWHV00Iavty9T 8IsF7ISIwMr9kVrM/q7yYnx6VOCzyl42dRaG4EaJg7AP4xu9H/dZAt7mLP2NR0M/R+NE wWEw== X-Gm-Message-State: APjAAAW27UR2qArcgn1ZlrPsUIdnG2Uk/5WUafBMvjawQv4i4ZX1jWJz nXw3YKBtk/vRxG14kp0/V9ekIt2tLYsodQ== X-Received: by 2002:ac2:4add:: with SMTP id m29mr3623584lfp.190.1579637704254; Tue, 21 Jan 2020 12:15:04 -0800 (PST) Received: from kynes ([217.153.94.18]) by smtp.gmail.com with ESMTPSA id e17sm19243713ljg.101.2020.01.21.12.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 12:15:03 -0800 (PST) Date: Tue, 21 Jan 2020 21:15:01 +0100 From: =?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek To: linux-bluetooth@vger.kernel.org Cc: brian.gix@intel.com, inga.stotland@intel.com Subject: Re: [RFC BlueZ 0/2] Fix types and names of beacon/import flags. Message-ID: <20200121201501.v4ceigg5xngfvjb4@kynes> Mail-Followup-To: linux-bluetooth@vger.kernel.org, brian.gix@intel.com, inga.stotland@intel.com References: <20200109083855.16000-1-michal.lowas-rzechonek@silvair.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200109083855.16000-1-michal.lowas-rzechonek@silvair.com> User-Agent: NeoMutt/20180716 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Brian, Inga, On 01/09, Michał Lowas-Rzechonek wrote: > This patchset aims to make the API a bit more consistent. > > Side question: at the moment none of the node properties emit > PropertiesChanged signal. I think this violates D-Bus spec, since all > properties are assumed to emit these signals by default [1] [2]. > > Unfortunately, at the moment ELL does not support "EmitsChangedSignal" > annotation, so I'd like to add this to ELL, annotate node > properties with: > - Features: const > - Beacon: true > - BeaconFlags: true > - IvIndex: true > - SecondsSinceLastHeard: false (for performance reasons) > - Addresses: const > > And also emit PropertiesChanged where required. > > Thoughts? Any comments about this idea, or should I just go ahead and send a patch? -- Michał Lowas-Rzechonek Silvair http://silvair.com Jasnogórska 44, 31-358 Krakow, POLAND