Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200117132754.BlueZ.1.I56a225147d9cabef55f94b57129a5e37ea79d165@changeid>
 <20200117132754.BlueZ.2.Ie24be91b472c0a274606191bc4d14df030fe3598@changeid>
 <CABBYNZJBf_FxO-=nVRqtC9MPEsD8dyXoGhFQPRYg0SB4wQG51Q@mail.gmail.com> <CABBYNZLV_x5zv_McY1bA1253B2j=Yn8KHHiH59xg=eBy07P70w@mail.gmail.com>
In-Reply-To: <CABBYNZLV_x5zv_McY1bA1253B2j=Yn8KHHiH59xg=eBy07P70w@mail.gmail.com>
From:   Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Date:   Tue, 21 Jan 2020 14:23:40 -0800
Message-ID: <CANFp7mWkZoOmwobknVMynOTvOV4=3Vi6U9wmFoy9iktoODfzpA@mail.gmail.com>
Subject: Re: [BlueZ PATCH 2/2] input: Make HID devices wake capable
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Alain Michaud <alainm@chromium.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        chromeos-bluetooth-upstreaming@chromium.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hey Luiz,

Yes, I will be following up. I sent an email on Friday but I think
with html so it may have been lost.
Will resend the patches today with wake_capable exposed via dbus and
not automatically set by the profile.

Abhishek

On Tue, Jan 21, 2020 at 2:15 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Abhishek,
>
> On Fri, Jan 17, 2020 at 2:16 PM Luiz Augusto von Dentz
> <luiz.dentz@gmail.com> wrote:
> >
> > Hi Abhishek,
> >
> > On Fri, Jan 17, 2020 at 1:28 PM Abhishek Pandit-Subedi
> > <abhishekpandit@chromium.org> wrote:
> > >
> > > HID devices can wake the host from a suspended state. Mark them as wake
> > > capable when they are accepted.
> >
> > My suggestion is that we do this via application so we let the user
> > decide if he wants or not to wake up the system, you may still opt-in
> > to always enable to wake up in your system setting if you choose to,
> > going this route actually means the user can select not to wake up if
> > the device is somewhat broken or misbehaving in some respect which is
> > not that uncommon nowadays.
>
> Will there be any follow up on this or you didn't quite understand
> what Im suggesting here?
>
> > > ---
> > >
> > >  profiles/input/device.c | 1 +
> > >  profiles/input/hog.c    | 1 +
> > >  2 files changed, 2 insertions(+)
> > >
> > > diff --git a/profiles/input/device.c b/profiles/input/device.c
> > > index 2cb3811c8..a6b0e8053 100644
> > > --- a/profiles/input/device.c
> > > +++ b/profiles/input/device.c
> > > @@ -1381,6 +1381,7 @@ int input_device_register(struct btd_service *service)
> > >         }
> > >
> > >         btd_service_set_user_data(service, idev);
> > > +       device_set_wake_capable(device, true);
> > >
> > >         return 0;
> > >  }
> > > diff --git a/profiles/input/hog.c b/profiles/input/hog.c
> > > index 83c017dcb..8627f3557 100644
> > > --- a/profiles/input/hog.c
> > > +++ b/profiles/input/hog.c
> > > @@ -159,6 +159,7 @@ static int hog_probe(struct btd_service *service)
> > >                 return -EINVAL;
> > >
> > >         btd_service_set_user_data(service, dev);
> > > +       device_set_wake_capable(device, true);
> > >         return 0;
> > >  }
> > >
> > > --
> > > 2.25.0.341.g760bfbb309-goog
> > >
> >
> >
> > --
> > Luiz Augusto von Dentz
>
>
>
> --
> Luiz Augusto von Dentz