Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200125004350.4640-1-brian.gix@intel.com> <CAFcXi1x4skUJuCgQLDswFQm20Hqo8XdAwmGv8qTg+ywKyjPGxg@mail.gmail.com>
In-Reply-To: <CAFcXi1x4skUJuCgQLDswFQm20Hqo8XdAwmGv8qTg+ywKyjPGxg@mail.gmail.com>
From:   =?UTF-8?B?UmFmYcWCIEdhamRh?= <rafal.gajda@silvair.com>
Date:   Tue, 28 Jan 2020 12:26:43 +0100
Message-ID: <CAFcXi1w3=MgG1e57B_e-yyg6zfHRFL--crCZ-8aGfBvxTNVGfw@mail.gmail.com>
Subject: Re: [PATCH BlueZ v2 0/5] mesh: Add NVM storage of Replay Protection List
To:     Brian Gix <brian.gix@intel.com>
Cc:     linux-bluetooth@vger.kernel.org, inga.stotland@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi,

pon., 27 sty 2020 o 22:27 Rafa=C5=82 Gajda <rafal.gajda@silvair.com> napisa=
=C5=82(a):
>
> It looks like sequence number is correctly incremented when calling
> DevKeySend but it isn't incremented at all when ConfigModel sends the
> reply back.

I think the culprit is in mesh/net.c in mesh_net_app_send() line 3160:

> /* First enqueue to any Friends and internal models */
>     result =3D msg_rxed(net, false, iv_index, ttl,
>     seq + seg_max,
>     net_idx,
>     src, dst,
>     key_aid,szmic, seq & SEQ_ZERO_MASK,
>     msg, msg_len);
>
> /* If addressed to a unicast address and successfully enqueued,
> * or delivered to one of our Unicast addresses we are done
> */
> if ((result && IS_UNICAST(dst)) || src =3D=3D dst ||
>     (dst >=3D net->src_addr && dst <=3D net->last_addr)) {
>     /* Adjust our seq_num for "virtual" delivery */
>     net->seq_num +=3D seg_max;
>     return true;
> }

When sending the message we first deliver it to internal models and
only after that we increment the msg sequence number.
If we do "net->seq_num +=3D seg_max" before calling msg_rxed() then
messages are delivered correctly.

--=20

Rafa=C5=82 Gajda
Silvair Sp. z o.o.