Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200128020505.239349-1-abhishekpandit@chromium.org>
In-Reply-To: <20200128020505.239349-1-abhishekpandit@chromium.org>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 28 Jan 2020 12:31:12 -0800
Message-ID: <CABBYNZ+fRVSBxbX-3D-WxK=Z4TxnkHbWMPusv+owrRAsKdEOkw@mail.gmail.com>
Subject: Re: [BlueZ PATCH v3 0/5] device: Allow devices to be marked as wake capable
To:     Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Alain Michaud <alainm@chromium.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        chromeos-bluetooth-upstreaming@chromium.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Abhishek,

On Mon, Jan 27, 2020 at 6:05 PM Abhishek Pandit-Subedi
<abhishekpandit@chromium.org> wrote:
>
>
> Hi bluez maintainers,
>
> This change accompanies changes in the kernel to mark HID devices as
> wake capable so they can wake the system from suspend. The
> implementation depends on the Set Wake Capable management operation. It
> is currently a separate management operation but it may be added as an
> extension to an exiting operand like add_device (need some feedback
> regarding this).
>
> Per request on the last patch, I've moved docs/mgmt-api.txt into its own
> patch so we can continue discussions on it.
>
> This change was tested with appropriate kernel changes on v4.19
> (verified that HID devices were being marked as wake capable in the
> kernel).
>
> Thanks
> Abhishek
>
> Changes in v3:
> * Added profile_wake_support and made wake_capable dependent on it
> * Added documentation for WakeCapable
> * Mark HID device to support wake from suspend
>
> Changes in v2:
> * Separated docs/mgmt-api.txt into its own patch
> * Added dbus api "WakeCapable" to set value
> * Update device_set_wake_capable to be called by
>   adapter_set_wake_capable_complete so we can emit property changed
> * Newly added to show whether device is wake capable
> * Removed automatically setting wake capable for HID devices
>
> Abhishek Pandit-Subedi (5):
>   mgmt: Add docs for Set Wake Capable
>   device: Allow device to be marked as wake capable
>   client: Display wake capable property with info
>   doc/device-api: Add WakeCapable
>   input: Make HID devices wake capable
>
>  client/main.c           |   1 +
>  doc/device-api.txt      |   5 ++
>  doc/mgmt-api.txt        |  19 +++++++
>  lib/mgmt.h              |   9 ++++
>  profiles/input/device.c |   1 +
>  profiles/input/hog.c    |   1 +
>  src/adapter.c           |  65 ++++++++++++++++++++++
>  src/adapter.h           |   2 +
>  src/device.c            | 116 ++++++++++++++++++++++++++++++++++++++++
>  src/device.h            |   5 ++
>  10 files changed, 224 insertions(+)
>
> --
> 2.25.0.341.g760bfbb309-goog

Other than the small comments I had this set is quite good, does the
kernel support has already been merged?

-- 
Luiz Augusto von Dentz