Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
Subject: Re: bluetooth: If unknown option in L2CAP Configuration Request is a
 hint, Bluetooth stack responds with "Command Reject" instead of
 "Configuration Response"
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <3020b8d0c7d39428aec573153b3c3414213be7ce.camel@peiker-cee.de>
Date:   Wed, 29 Jan 2020 04:56:16 +0100
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <89F234DA-089E-4F45-9D32-7A09CC52E8CD@holtmann.org>
References: <3020b8d0c7d39428aec573153b3c3414213be7ce.camel@peiker-cee.de>
To:     Konstantin Forostyan <konstantin.forostyan@peiker-cee.de>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Konstantin,

> It seems that there's a bug in Bluetooth stack of 4.20 kernel. I
> discovered it during Bluetooth qualification tests. L2CAP/COS/CFD/BV-
> 12-C [Unknown Option Response] test fails because instead of
> "Configuration Response" with error code 0x0003 "unknown option" the
> Bluetooth stack generates "Command Reject".
> 
> I think, this happens because the tester (Bluetooth SIG PTS) uses hints
> as unknown options, and the Bluetooth stack has special handling for
> hints. 
> 
> I made a small patch in order to overcome this problem. Please confirm,
> that the patch is feasible. If not, please suggest how to fix the
> "Command Reject" problem.

is the limited to 4.20 kernel or does it also happen with the latest 5.5 kernel?

Regards

Marcel