Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
Subject: Re: [PATCH v1] Bluetooth: hci_qca: Bug fixes while collecting
 controller memory dump
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <d89347d22c12ffca5ccf4e18e0c716ab@codeaurora.org>
Date:   Wed, 5 Feb 2020 13:52:05 +0100
Cc:     Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Matthias Kaehlcke <mka@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Bluez mailing list <linux-bluetooth@vger.kernel.org>,
        robh@kernel.org, hemantg@codeaurora.org,
        linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org,
        tientzu@chromium.org, seanpaul@chromium.org, rjliao@codeaurora.org,
        Yoni Shavit <yshavit@google.com>
Content-Transfer-Encoding: 8BIT
Message-Id: <20C0BA0B-1069-4DCF-A8FA-3B6359621D30@holtmann.org>
References: <1580832929-2067-1-git-send-email-gubbaven@codeaurora.org>
 <CANFp7mXgvfQGw0bc0dwNXg9KME1XD1zYGtPdEFWbM20NJpKtzQ@mail.gmail.com>
 <d89347d22c12ffca5ccf4e18e0c716ab@codeaurora.org>
To:     Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Venkata,

>> Hi Venkata,
>> Per our earlier review on chromium gerrit:
>> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1992966
>> I'm not too keen on the change from mutex to spinlock because it's
>> made the code more complex.
> [Venkata] :
> 
> We have moved from mutex to spinlock as timer callback function is getting executed under interrupt context and not under process context.

can’t you use a delayed workqueue for this?

Regards

Marcel