Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
Subject: Re: [Bluez PATCH v3] core: Add new policy for Just-Works repairing
From:   Johan Hedberg <johan.hedberg@gmail.com>
In-Reply-To: <20200214114350.Bluez.v3.1.I333a90ad3c75882c6f008c94a28ca7d3e8f6c76e@changeid>
Date:   Fri, 14 Feb 2020 09:33:07 +0200
Cc:     Bluez mailing list <linux-bluetooth@vger.kernel.org>,
        Luiz Von Dentz <luiz.von.dentz@intel.com>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1BEAEE28-6159-491D-BCCC-4C5298891987@gmail.com>
References: <20200214114350.Bluez.v3.1.I333a90ad3c75882c6f008c94a28ca7d3e8f6c76e@changeid>
To:     Howard Chung <howardchung@google.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Howard,

On 14. Feb 2020, at 5.45, Howard Chung <howardchung@google.com> wrote:
> @@ -6141,6 +6141,22 @@ int device_confirm_passkey(struct btd_device =
*device, uint8_t type,
> 	struct authentication_req *auth;
> 	int err;
>=20
> +	/* Just-Works repairing policy */
> +	if (confirm_hint && (device_is_paired(device, BDADDR_BREDR) ||
> +				device_is_paired(device, =
BDADDR_LE_PUBLIC))) {

Wouldn=E2=80=99t a single call to device_is_paired() using =E2=80=9Ctype=E2=
=80=9D (the address type that=E2=80=99s part of the mgmt event) be the =
right thing to do here?

Johan=