Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200214114350.Bluez.v3.1.I333a90ad3c75882c6f008c94a28ca7d3e8f6c76e@changeid>
 <1BEAEE28-6159-491D-BCCC-4C5298891987@gmail.com>
In-Reply-To: <1BEAEE28-6159-491D-BCCC-4C5298891987@gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 14 Feb 2020 10:26:29 -0800
Message-ID: <CABBYNZ+x5r_YY7jJ=oDdpcshvvoJWm_eXpj+DbCbFGg79R4j-w@mail.gmail.com>
Subject: Re: [Bluez PATCH v3] core: Add new policy for Just-Works repairing
To:     Johan Hedberg <johan.hedberg@gmail.com>
Cc:     Howard Chung <howardchung@google.com>,
        Bluez mailing list <linux-bluetooth@vger.kernel.org>,
        Luiz Von Dentz <luiz.von.dentz@intel.com>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Howard,

On Thu, Feb 13, 2020 at 11:35 PM Johan Hedberg <johan.hedberg@gmail.com> wr=
ote:
>
> Hi Howard,
>
> On 14. Feb 2020, at 5.45, Howard Chung <howardchung@google.com> wrote:
> > @@ -6141,6 +6141,22 @@ int device_confirm_passkey(struct btd_device *de=
vice, uint8_t type,
> >       struct authentication_req *auth;
> >       int err;
> >
> > +     /* Just-Works repairing policy */
> > +     if (confirm_hint && (device_is_paired(device, BDADDR_BREDR) ||
> > +                             device_is_paired(device, BDADDR_LE_PUBLIC=
))) {
>
> Wouldn=E2=80=99t a single call to device_is_paired() using =E2=80=9Ctype=
=E2=80=9D (the address type that=E2=80=99s part of the mgmt event) be the r=
ight thing to do here?

+1, other than that it looks pretty good now so we should be able to
merge after this change.

--=20
Luiz Augusto von Dentz